From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915: Fix cdclk vs. dev_cdclk mess when not recomputing things Date: Tue, 1 Nov 2016 14:41:37 +0200 Message-ID: <20161101124137.GT4617@intel.com> References: <1477673960-3274-1-git-send-email-ville.syrjala@linux.intel.com> <1354f7bd-a473-f941-cd79-d1fc7259fa38@linux.intel.com> <1477991271.2230.40.camel@tiscali.nl> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3157589A74 for ; Tue, 1 Nov 2016 12:41:42 +0000 (UTC) Content-Disposition: inline In-Reply-To: <1477991271.2230.40.camel@tiscali.nl> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Paul Bolle Cc: bruno.pagani@ens-lyon.org, Daniel J Blueman , intel-gfx@lists.freedesktop.org, stable@vger.kernel.org, Joseph Yasi List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBOb3YgMDEsIDIwMTYgYXQgMTA6MDc6NTFBTSArMDEwMCwgUGF1bCBCb2xsZSB3cm90 ZToKPiBPbiBUdWUsIDIwMTYtMTEtMDEgYXQgMDk6NTcgKzAxMDAsIE1hYXJ0ZW4gTGFua2hvcnN0 IHdyb3RlOgo+ID4gT3RoZXJ3aXNlIGxvb2tzIHNhbmUsIEkgaGF2ZSBhIHNpbWlsYXIgcGF0Y2gg aW4gbXkgdHJlZS4gSSBkaWRuJ3QKPiA+IHN1Ym1pdCBpdCB5ZXQgYnV0IHRoZSBmaXggd2FzIHNp bWlsYXIuIEV4Y2VwdCBmb3IgdGhlCj4gPiBkZXZfY2RjbGsgc3R1ZmYuCj4gPiAKPiA+IFdpdGgg dGhlIGxhc3QgZGV2X2NkY2xrIGFzc2lnbm1lbnQgcmVtb3ZlZDoKPiA+IAo+ID4gUmV2aWV3ZWQt Ynk6IE1hYXJ0ZW4gTGFua2hvcnN0IDxtYWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5jb20+ Cj4gCj4gU28gSSd2ZSBiZWVuIHJ1bm5pbmcgdGhpcyBwYXRjaCBmb3IgYSBmZXcgZGF5cyBub3cu IEZpcnN0IEkgdGVzdGVkIGl0Cj4gb24gdG9wIG9mIHY0LjguNC4gTm93IEknbSBydW5uaW5nIGl0 IG9uIHRvcCBvZiB2NC44LjUuCj4gCj4gTXkgY3VycmVudCB2NC44LjUgYm9vdCBzYXcgdGhpcyBu ZXcgKGZvciBtZSkgKkVSUk9SKiwgdHdpY2U6Cj4gwqAgwqDCoDwzPls0MzQ4My41MjEzNDFdIFtk cm06c2tsX3NldF9jZGNsayBbaTkxNV1dICpFUlJPUiogZmFpbGVkIHRvIGluZm9ybSBQQ1UgYWJv dXQgY2RjbGsgY2hhbmdlCj4gICAgIDwzPlsxMDg2MzkuMDkwNzc2XSBbZHJtOnNrbF9zZXRfY2Rj bGsgW2k5MTVdXSAqRVJST1IqIGZhaWxlZCB0byBpbmZvcm0gUENVIGFib3V0IGNkY2xrIGNoYW5n ZQo+IAo+IFJlbGF0ZWQgb3IgYSBjb2luY2lkZW5jZT8KCk5vdCBkaXJlY3RseSByZWxhdGVkLiBU aGF0J3MgYWN0dWFsbHkgYSBtb3JlIHNlcmlvdXMgcHJvYmxlbSB3ZSByZWFsbHkKbmVlZCB0byBm aWd1cmUgb3V0LiBJIGFscmVhZHkgdHJpZWQgdG8gZml4IGl0IGJ1dCBhcHBhcmVudGx5IEkgZmFp bGVkLgoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbCBPVEMKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1n ZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com ([192.55.52.43]:12338 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1167711AbcKAMlm (ORCPT ); Tue, 1 Nov 2016 08:41:42 -0400 Date: Tue, 1 Nov 2016 14:41:37 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Paul Bolle Cc: Maarten Lankhorst , intel-gfx@lists.freedesktop.org, Mika Kahola , bruno.pagani@ens-lyon.org, Daniel J Blueman , Joseph Yasi , stable@vger.kernel.org Subject: Re: [PATCH] drm/i915: Fix cdclk vs. dev_cdclk mess when not recomputing things Message-ID: <20161101124137.GT4617@intel.com> References: <1477673960-3274-1-git-send-email-ville.syrjala@linux.intel.com> <1354f7bd-a473-f941-cd79-d1fc7259fa38@linux.intel.com> <1477991271.2230.40.camel@tiscali.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1477991271.2230.40.camel@tiscali.nl> Sender: stable-owner@vger.kernel.org List-ID: On Tue, Nov 01, 2016 at 10:07:51AM +0100, Paul Bolle wrote: > On Tue, 2016-11-01 at 09:57 +0100, Maarten Lankhorst wrote: > > Otherwise looks sane, I have a similar patch in my tree. I didn't > > submit it yet but the fix was similar. Except for the > > dev_cdclk stuff. > > > > With the last dev_cdclk assignment removed: > > > > Reviewed-by: Maarten Lankhorst > > So I've been running this patch for a few days now. First I tested it > on top of v4.8.4. Now I'm running it on top of v4.8.5. > > My current v4.8.5 boot saw this new (for me) *ERROR*, twice: > � ��<3>[43483.521341] [drm:skl_set_cdclk [i915]] *ERROR* failed to inform PCU about cdclk change > <3>[108639.090776] [drm:skl_set_cdclk [i915]] *ERROR* failed to inform PCU about cdclk change > > Related or a coincidence? Not directly related. That's actually a more serious problem we really need to figure out. I already tried to fix it but apparently I failed. -- Ville Syrj�l� Intel OTC