All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Omar Sandoval <osandov@osandov.com>
Cc: Christoph Hellwig <hch@lst.de>,
	axboe@fb.com, linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] block: fast-path for small and simple direct I/O requests
Date: Tue, 1 Nov 2016 15:18:16 +0100	[thread overview]
Message-ID: <20161101141816.GA17142@lst.de> (raw)
In-Reply-To: <20161031231911.GA20713@vader>

On Mon, Oct 31, 2016 at 04:19:11PM -0700, Omar Sandoval wrote:
> > +	if (unlikely(ret))
> > +		return ret;
> > +	ret = bio.bi_iter.bi_size;
> > +
> > +	if (iov_iter_rw(iter) == READ) {
> > +		bio_set_op_attrs(&bio, REQ_OP_READ, 0);
> > +		if (iter->type == ITER_IOVEC)
> 
> Nit: iter_is_iovec()?

Fixed.


  reply	other threads:[~2016-11-01 14:18 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-31 17:59 block device direct I/O fast path Christoph Hellwig
2016-10-31 17:59 ` [PATCH 1/2] block: add bio_iov_iter_get_pages() Christoph Hellwig
2016-11-01  1:05   ` Ming Lei
2016-11-01 14:19     ` Christoph Hellwig
2016-10-31 17:59 ` [PATCH 2/2] block: fast-path for small and simple direct I/O requests Christoph Hellwig
2016-10-31 23:19   ` Omar Sandoval
2016-11-01 14:18     ` Christoph Hellwig [this message]
2016-11-01 17:00 ` block device direct I/O fast path Jens Axboe
2016-11-01 17:06   ` Christoph Hellwig
2016-11-01 17:54     ` Jens Axboe
2016-11-01 18:22       ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161101141816.GA17142@lst.de \
    --to=hch@lst.de \
    --cc=axboe@fb.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=osandov@osandov.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.