From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48286) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c1cJP-0004AM-QZ for qemu-devel@nongnu.org; Tue, 01 Nov 2016 12:53:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c1cJL-0005y0-0M for qemu-devel@nongnu.org; Tue, 01 Nov 2016 12:53:23 -0400 Received: from smtp02.citrix.com ([66.165.176.63]:15880) by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71) (envelope-from ) id 1c1cJK-0005xt-Qn for qemu-devel@nongnu.org; Tue, 01 Nov 2016 12:53:18 -0400 Date: Tue, 1 Nov 2016 16:53:17 +0000 From: Wei Liu Message-ID: <20161101165317.GD30231@citrix.com> References: <1478018591-26425-1-git-send-email-wei.liu2@citrix.com> <20161101164827.GZ5057@thinpad.lan.raisama.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20161101164827.GZ5057@thinpad.lan.raisama.net> Subject: Re: [Qemu-devel] [PATCH RFC] PCMachineState: introduce acpi_build_enabled field List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: Wei Liu , qemu-devel@nongnu.org, Xen-devel , Igor Mammedov , Anthony PERARD , Stefano Stabellini , Sander Eikelenboom On Tue, Nov 01, 2016 at 02:48:27PM -0200, Eduardo Habkost wrote: [...] > > static void pc_machine_set_nvdimm(Object *obj, bool value, Error **errp) > > { > > PCMachineState *pcms = PC_MACHINE(obj); > > @@ -2159,6 +2173,8 @@ static void pc_machine_initfn(Object *obj) > > pcms->vmport = ON_OFF_AUTO_AUTO; > > /* nvdimm is disabled on default. */ > > pcms->acpi_nvdimm_state.is_enabled = false; > > + /* acpi build is enabled by default. */ > > + pcms->acpi_build_enabled = true; > > If you set: > pcms->acpi_build_enabled = PC_MACHINE_GET_CLASS(pcms)->has_acpi_build; > the default value will be more consistent with the actual results > (where pc-1.6 and older don't have ACPI build). Then you would > probably be able to remove the pcmc->has_acpi_build check from > acpi_setup() and only check pcms->acpi_build_enabled. > Thank you for your good advice. I take it that you're ok with the name of the field and the code in general? If so I will drop RFC tag in my next submission. Wei. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Liu Subject: Re: [PATCH RFC] PCMachineState: introduce acpi_build_enabled field Date: Tue, 1 Nov 2016 16:53:17 +0000 Message-ID: <20161101165317.GD30231@citrix.com> References: <1478018591-26425-1-git-send-email-wei.liu2@citrix.com> <20161101164827.GZ5057@thinpad.lan.raisama.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c1cJN-00036e-4P for xen-devel@lists.xenproject.org; Tue, 01 Nov 2016 16:53:21 +0000 Content-Disposition: inline In-Reply-To: <20161101164827.GZ5057@thinpad.lan.raisama.net> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Eduardo Habkost Cc: Stefano Stabellini , Wei Liu , qemu-devel@nongnu.org, Sander Eikelenboom , Igor Mammedov , Anthony PERARD , Xen-devel List-Id: xen-devel@lists.xenproject.org T24gVHVlLCBOb3YgMDEsIDIwMTYgYXQgMDI6NDg6MjdQTSAtMDIwMCwgRWR1YXJkbyBIYWJrb3N0 IHdyb3RlOgpbLi4uXQo+ID4gIHN0YXRpYyB2b2lkIHBjX21hY2hpbmVfc2V0X252ZGltbShPYmpl Y3QgKm9iaiwgYm9vbCB2YWx1ZSwgRXJyb3IgKiplcnJwKQo+ID4gIHsKPiA+ICAgICAgUENNYWNo aW5lU3RhdGUgKnBjbXMgPSBQQ19NQUNISU5FKG9iaik7Cj4gPiBAQCAtMjE1OSw2ICsyMTczLDgg QEAgc3RhdGljIHZvaWQgcGNfbWFjaGluZV9pbml0Zm4oT2JqZWN0ICpvYmopCj4gPiAgICAgIHBj bXMtPnZtcG9ydCA9IE9OX09GRl9BVVRPX0FVVE87Cj4gPiAgICAgIC8qIG52ZGltbSBpcyBkaXNh YmxlZCBvbiBkZWZhdWx0LiAqLwo+ID4gICAgICBwY21zLT5hY3BpX252ZGltbV9zdGF0ZS5pc19l bmFibGVkID0gZmFsc2U7Cj4gPiArICAgIC8qIGFjcGkgYnVpbGQgaXMgZW5hYmxlZCBieSBkZWZh dWx0LiAqLwo+ID4gKyAgICBwY21zLT5hY3BpX2J1aWxkX2VuYWJsZWQgPSB0cnVlOwo+IAo+IElm IHlvdSBzZXQ6Cj4gICBwY21zLT5hY3BpX2J1aWxkX2VuYWJsZWQgPSBQQ19NQUNISU5FX0dFVF9D TEFTUyhwY21zKS0+aGFzX2FjcGlfYnVpbGQ7Cj4gdGhlIGRlZmF1bHQgdmFsdWUgd2lsbCBiZSBt b3JlIGNvbnNpc3RlbnQgd2l0aCB0aGUgYWN0dWFsIHJlc3VsdHMKPiAod2hlcmUgcGMtMS42IGFu ZCBvbGRlciBkb24ndCBoYXZlIEFDUEkgYnVpbGQpLiBUaGVuIHlvdSB3b3VsZAo+IHByb2JhYmx5 IGJlIGFibGUgdG8gcmVtb3ZlIHRoZSBwY21jLT5oYXNfYWNwaV9idWlsZCBjaGVjayBmcm9tCj4g YWNwaV9zZXR1cCgpIGFuZCBvbmx5IGNoZWNrIHBjbXMtPmFjcGlfYnVpbGRfZW5hYmxlZC4KPiAK ClRoYW5rIHlvdSBmb3IgeW91ciBnb29kIGFkdmljZS4KCkkgdGFrZSBpdCB0aGF0IHlvdSdyZSBv ayB3aXRoIHRoZSBuYW1lIG9mIHRoZSBmaWVsZCBhbmQgdGhlIGNvZGUgaW4KZ2VuZXJhbD8gSWYg c28gSSB3aWxsIGRyb3AgUkZDIHRhZyBpbiBteSBuZXh0IHN1Ym1pc3Npb24uCgpXZWkuCgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFp bGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW4ub3JnCmh0dHBzOi8vbGlzdHMueGVuLm9yZy94 ZW4tZGV2ZWwK