From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50746) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c1cRD-0002jG-Os for qemu-devel@nongnu.org; Tue, 01 Nov 2016 13:01:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c1cR8-0000IT-Af for qemu-devel@nongnu.org; Tue, 01 Nov 2016 13:01:27 -0400 Received: from smtp02.citrix.com ([66.165.176.63]:35088) by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71) (envelope-from ) id 1c1cR8-0000IF-5N for qemu-devel@nongnu.org; Tue, 01 Nov 2016 13:01:22 -0400 Date: Tue, 1 Nov 2016 17:01:19 +0000 From: Wei Liu Message-ID: <20161101170119.GF30231@citrix.com> References: <1478018591-26425-1-git-send-email-wei.liu2@citrix.com> <20161101164827.GZ5057@thinpad.lan.raisama.net> <20161101165317.GD30231@citrix.com> <20161101165925.GA5057@thinpad.lan.raisama.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20161101165925.GA5057@thinpad.lan.raisama.net> Subject: Re: [Qemu-devel] [PATCH RFC] PCMachineState: introduce acpi_build_enabled field List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: Wei Liu , qemu-devel@nongnu.org, Xen-devel , Igor Mammedov , Anthony PERARD , Stefano Stabellini , Sander Eikelenboom On Tue, Nov 01, 2016 at 02:59:25PM -0200, Eduardo Habkost wrote: > On Tue, Nov 01, 2016 at 04:53:17PM +0000, Wei Liu wrote: > > On Tue, Nov 01, 2016 at 02:48:27PM -0200, Eduardo Habkost wrote: > > [...] > > > > static void pc_machine_set_nvdimm(Object *obj, bool value, Error **errp) > > > > { > > > > PCMachineState *pcms = PC_MACHINE(obj); > > > > @@ -2159,6 +2173,8 @@ static void pc_machine_initfn(Object *obj) > > > > pcms->vmport = ON_OFF_AUTO_AUTO; > > > > /* nvdimm is disabled on default. */ > > > > pcms->acpi_nvdimm_state.is_enabled = false; > > > > + /* acpi build is enabled by default. */ > > > > + pcms->acpi_build_enabled = true; > > > > > > If you set: > > > pcms->acpi_build_enabled = PC_MACHINE_GET_CLASS(pcms)->has_acpi_build; > > > the default value will be more consistent with the actual results > > > (where pc-1.6 and older don't have ACPI build). Then you would > > > probably be able to remove the pcmc->has_acpi_build check from > > > acpi_setup() and only check pcms->acpi_build_enabled. > > > > > > > Thank you for your good advice. > > > > I take it that you're ok with the name of the field and the code in > > general? If so I will drop RFC tag in my next submission. > > The rest looks good to me, except that I don't see a reason to > add a "acpi-build" property if it's not used for anything (all > code is using the struct field directly). > OK. I'm fine with deleting that. I was just following existing examples. Wei. > -- > Eduardo From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Liu Subject: Re: [PATCH RFC] PCMachineState: introduce acpi_build_enabled field Date: Tue, 1 Nov 2016 17:01:19 +0000 Message-ID: <20161101170119.GF30231@citrix.com> References: <1478018591-26425-1-git-send-email-wei.liu2@citrix.com> <20161101164827.GZ5057@thinpad.lan.raisama.net> <20161101165317.GD30231@citrix.com> <20161101165925.GA5057@thinpad.lan.raisama.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c1cRA-0004GA-ON for xen-devel@lists.xenproject.org; Tue, 01 Nov 2016 17:01:24 +0000 Content-Disposition: inline In-Reply-To: <20161101165925.GA5057@thinpad.lan.raisama.net> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Eduardo Habkost Cc: Stefano Stabellini , Wei Liu , qemu-devel@nongnu.org, Sander Eikelenboom , Igor Mammedov , Anthony PERARD , Xen-devel List-Id: xen-devel@lists.xenproject.org T24gVHVlLCBOb3YgMDEsIDIwMTYgYXQgMDI6NTk6MjVQTSAtMDIwMCwgRWR1YXJkbyBIYWJrb3N0 IHdyb3RlOgo+IE9uIFR1ZSwgTm92IDAxLCAyMDE2IGF0IDA0OjUzOjE3UE0gKzAwMDAsIFdlaSBM aXUgd3JvdGU6Cj4gPiBPbiBUdWUsIE5vdiAwMSwgMjAxNiBhdCAwMjo0ODoyN1BNIC0wMjAwLCBF ZHVhcmRvIEhhYmtvc3Qgd3JvdGU6Cj4gPiBbLi4uXQo+ID4gPiA+ICBzdGF0aWMgdm9pZCBwY19t YWNoaW5lX3NldF9udmRpbW0oT2JqZWN0ICpvYmosIGJvb2wgdmFsdWUsIEVycm9yICoqZXJycCkK PiA+ID4gPiAgewo+ID4gPiA+ICAgICAgUENNYWNoaW5lU3RhdGUgKnBjbXMgPSBQQ19NQUNISU5F KG9iaik7Cj4gPiA+ID4gQEAgLTIxNTksNiArMjE3Myw4IEBAIHN0YXRpYyB2b2lkIHBjX21hY2hp bmVfaW5pdGZuKE9iamVjdCAqb2JqKQo+ID4gPiA+ICAgICAgcGNtcy0+dm1wb3J0ID0gT05fT0ZG X0FVVE9fQVVUTzsKPiA+ID4gPiAgICAgIC8qIG52ZGltbSBpcyBkaXNhYmxlZCBvbiBkZWZhdWx0 LiAqLwo+ID4gPiA+ICAgICAgcGNtcy0+YWNwaV9udmRpbW1fc3RhdGUuaXNfZW5hYmxlZCA9IGZh bHNlOwo+ID4gPiA+ICsgICAgLyogYWNwaSBidWlsZCBpcyBlbmFibGVkIGJ5IGRlZmF1bHQuICov Cj4gPiA+ID4gKyAgICBwY21zLT5hY3BpX2J1aWxkX2VuYWJsZWQgPSB0cnVlOwo+ID4gPiAKPiA+ ID4gSWYgeW91IHNldDoKPiA+ID4gICBwY21zLT5hY3BpX2J1aWxkX2VuYWJsZWQgPSBQQ19NQUNI SU5FX0dFVF9DTEFTUyhwY21zKS0+aGFzX2FjcGlfYnVpbGQ7Cj4gPiA+IHRoZSBkZWZhdWx0IHZh bHVlIHdpbGwgYmUgbW9yZSBjb25zaXN0ZW50IHdpdGggdGhlIGFjdHVhbCByZXN1bHRzCj4gPiA+ ICh3aGVyZSBwYy0xLjYgYW5kIG9sZGVyIGRvbid0IGhhdmUgQUNQSSBidWlsZCkuIFRoZW4geW91 IHdvdWxkCj4gPiA+IHByb2JhYmx5IGJlIGFibGUgdG8gcmVtb3ZlIHRoZSBwY21jLT5oYXNfYWNw aV9idWlsZCBjaGVjayBmcm9tCj4gPiA+IGFjcGlfc2V0dXAoKSBhbmQgb25seSBjaGVjayBwY21z LT5hY3BpX2J1aWxkX2VuYWJsZWQuCj4gPiA+IAo+ID4gCj4gPiBUaGFuayB5b3UgZm9yIHlvdXIg Z29vZCBhZHZpY2UuCj4gPiAKPiA+IEkgdGFrZSBpdCB0aGF0IHlvdSdyZSBvayB3aXRoIHRoZSBu YW1lIG9mIHRoZSBmaWVsZCBhbmQgdGhlIGNvZGUgaW4KPiA+IGdlbmVyYWw/IElmIHNvIEkgd2ls bCBkcm9wIFJGQyB0YWcgaW4gbXkgbmV4dCBzdWJtaXNzaW9uLgo+IAo+IFRoZSByZXN0IGxvb2tz IGdvb2QgdG8gbWUsIGV4Y2VwdCB0aGF0IEkgZG9uJ3Qgc2VlIGEgcmVhc29uIHRvCj4gYWRkIGEg ImFjcGktYnVpbGQiIHByb3BlcnR5IGlmIGl0J3Mgbm90IHVzZWQgZm9yIGFueXRoaW5nIChhbGwK PiBjb2RlIGlzIHVzaW5nIHRoZSBzdHJ1Y3QgZmllbGQgZGlyZWN0bHkpLgo+IAoKT0suIEknbSBm aW5lIHdpdGggZGVsZXRpbmcgdGhhdC4gSSB3YXMganVzdCBmb2xsb3dpbmcgZXhpc3RpbmcgZXhh bXBsZXMuCgpXZWkuCgo+IC0tIAo+IEVkdWFyZG8KCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxp c3RzLnhlbi5vcmcKaHR0cHM6Ly9saXN0cy54ZW4ub3JnL3hlbi1kZXZlbAo=