From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56966) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c1ccj-0004C1-Ph for qemu-devel@nongnu.org; Tue, 01 Nov 2016 13:13:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c1ccg-00042R-LB for qemu-devel@nongnu.org; Tue, 01 Nov 2016 13:13:21 -0400 Received: from smtp.citrix.com ([66.165.176.89]:15349) by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71) (envelope-from ) id 1c1ccg-00042J-G4 for qemu-devel@nongnu.org; Tue, 01 Nov 2016 13:13:18 -0400 Date: Tue, 1 Nov 2016 17:12:37 +0000 From: Wei Liu Message-ID: <20161101171237.GG30231@citrix.com> References: <1478018591-26425-1-git-send-email-wei.liu2@citrix.com> <20161101170231.GB5057@thinpad.lan.raisama.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20161101170231.GB5057@thinpad.lan.raisama.net> Subject: Re: [Qemu-devel] [PATCH RFC] PCMachineState: introduce acpi_build_enabled field List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: Wei Liu , qemu-devel@nongnu.org, Xen-devel , Igor Mammedov , Anthony PERARD , Stefano Stabellini , Sander Eikelenboom On Tue, Nov 01, 2016 at 03:02:31PM -0200, Eduardo Habkost wrote: > On Tue, Nov 01, 2016 at 04:43:11PM +0000, Wei Liu wrote: > [...] > > @@ -114,6 +115,11 @@ static void xen_change_state_handler(void *opaque, int running, > > > > static int xen_init(MachineState *ms) > > { > > + PCMachineState *pcms = PC_MACHINE(ms); > > + > > + /* Disable ACPI build because Xen handles it */ > > + pcms->acpi_build_enabled = false; > > I just noticed that I don't see any code to disable ACPI build in > the case of "-machine pc,accel=xen". I suggest a xen_enabled() Hmm... I think this code snippet does exactly that -- xen_init is the initialization function for Xen accelerator. So this covers -m xenfv (because it sets accelerator to xen) and -m whatever,accel=xen. Did I miss anything? Wei. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Liu Subject: Re: [PATCH RFC] PCMachineState: introduce acpi_build_enabled field Date: Tue, 1 Nov 2016 17:12:37 +0000 Message-ID: <20161101171237.GG30231@citrix.com> References: <1478018591-26425-1-git-send-email-wei.liu2@citrix.com> <20161101170231.GB5057@thinpad.lan.raisama.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c1cck-0005N5-Gd for xen-devel@lists.xenproject.org; Tue, 01 Nov 2016 17:13:22 +0000 Content-Disposition: inline In-Reply-To: <20161101170231.GB5057@thinpad.lan.raisama.net> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Eduardo Habkost Cc: Stefano Stabellini , Wei Liu , qemu-devel@nongnu.org, Sander Eikelenboom , Igor Mammedov , Anthony PERARD , Xen-devel List-Id: xen-devel@lists.xenproject.org T24gVHVlLCBOb3YgMDEsIDIwMTYgYXQgMDM6MDI6MzFQTSAtMDIwMCwgRWR1YXJkbyBIYWJrb3N0 IHdyb3RlOgo+IE9uIFR1ZSwgTm92IDAxLCAyMDE2IGF0IDA0OjQzOjExUE0gKzAwMDAsIFdlaSBM aXUgd3JvdGU6Cj4gWy4uLl0KPiA+IEBAIC0xMTQsNiArMTE1LDExIEBAIHN0YXRpYyB2b2lkIHhl bl9jaGFuZ2Vfc3RhdGVfaGFuZGxlcih2b2lkICpvcGFxdWUsIGludCBydW5uaW5nLAo+ID4gIAo+ ID4gIHN0YXRpYyBpbnQgeGVuX2luaXQoTWFjaGluZVN0YXRlICptcykKPiA+ICB7Cj4gPiArICAg IFBDTWFjaGluZVN0YXRlICpwY21zID0gUENfTUFDSElORShtcyk7Cj4gPiArCj4gPiArICAgIC8q IERpc2FibGUgQUNQSSBidWlsZCBiZWNhdXNlIFhlbiBoYW5kbGVzIGl0ICovCj4gPiArICAgIHBj bXMtPmFjcGlfYnVpbGRfZW5hYmxlZCA9IGZhbHNlOwo+IAo+IEkganVzdCBub3RpY2VkIHRoYXQg SSBkb24ndCBzZWUgYW55IGNvZGUgdG8gZGlzYWJsZSBBQ1BJIGJ1aWxkIGluCj4gdGhlIGNhc2Ug b2YgIi1tYWNoaW5lIHBjLGFjY2VsPXhlbiIuIEkgc3VnZ2VzdCBhIHhlbl9lbmFibGVkKCkKCkht bS4uLiBJIHRoaW5rIHRoaXMgY29kZSBzbmlwcGV0IGRvZXMgZXhhY3RseSB0aGF0IC0tIHhlbl9p bml0IGlzIHRoZQppbml0aWFsaXphdGlvbiBmdW5jdGlvbiBmb3IgWGVuIGFjY2VsZXJhdG9yLiBT byB0aGlzIGNvdmVycyAtbSB4ZW5mdgooYmVjYXVzZSBpdCBzZXRzIGFjY2VsZXJhdG9yIHRvIHhl bikgYW5kIC1tIHdoYXRldmVyLGFjY2VsPXhlbi4KCkRpZCBJIG1pc3MgYW55dGhpbmc/CgpXZWku CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2 ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW4ub3JnCmh0dHBzOi8vbGlzdHMueGVu Lm9yZy94ZW4tZGV2ZWwK