From mboxrd@z Thu Jan 1 00:00:00 1970 From: jon.mason@broadcom.com (Jon Mason) Date: Tue, 1 Nov 2016 16:59:14 -0400 Subject: [PATCH v4 2/7] Documentation: devicetree: add PHY lane swap binding In-Reply-To: <20161101204826.GA21010@lunn.ch> References: <1478030682-27012-1-git-send-email-jon.mason@broadcom.com> <1478030682-27012-3-git-send-email-jon.mason@broadcom.com> <20161101204826.GA21010@lunn.ch> Message-ID: <20161101205913.GA27191@broadcom.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Nov 01, 2016 at 09:48:26PM +0100, Andrew Lunn wrote: > > +- enet-phy-lane-swap: If set, indicates the PHY device requires swapping the > > + TX/RX lanes to function properly. > > Is 'requires' the right word here? The PHY performs the actual swap of > the Tx/Rx lanes. What I'm trying to say here is that without the lane swapping, the PHY will not function properly. Thus, those PHYs require this parameter to work. I am open to suggestions to reword the sentence to make it clearer. Thanks, Jon > > Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jon Mason Subject: Re: [PATCH v4 2/7] Documentation: devicetree: add PHY lane swap binding Date: Tue, 1 Nov 2016 16:59:14 -0400 Message-ID: <20161101205913.GA27191@broadcom.com> References: <1478030682-27012-1-git-send-email-jon.mason@broadcom.com> <1478030682-27012-3-git-send-email-jon.mason@broadcom.com> <20161101204826.GA21010@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20161101204826.GA21010-g2DYL2Zd6BY@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Andrew Lunn Cc: David Miller , Rob Herring , Mark Rutland , Florian Fainelli , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w@public.gmane.org, rafal-g1n6cQUeyibVItvQsEIGlw@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On Tue, Nov 01, 2016 at 09:48:26PM +0100, Andrew Lunn wrote: > > +- enet-phy-lane-swap: If set, indicates the PHY device requires swapping the > > + TX/RX lanes to function properly. > > Is 'requires' the right word here? The PHY performs the actual swap of > the Tx/Rx lanes. What I'm trying to say here is that without the lane swapping, the PHY will not function properly. Thus, those PHYs require this parameter to work. I am open to suggestions to reword the sentence to make it clearer. Thanks, Jon > > Andrew -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753706AbcKAU7b (ORCPT ); Tue, 1 Nov 2016 16:59:31 -0400 Received: from mail-pf0-f181.google.com ([209.85.192.181]:36264 "EHLO mail-pf0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752243AbcKAU73 (ORCPT ); Tue, 1 Nov 2016 16:59:29 -0400 Date: Tue, 1 Nov 2016 16:59:14 -0400 From: Jon Mason To: Andrew Lunn Cc: David Miller , Rob Herring , Mark Rutland , Florian Fainelli , devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, rafal@milecki.pl, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 2/7] Documentation: devicetree: add PHY lane swap binding Message-ID: <20161101205913.GA27191@broadcom.com> References: <1478030682-27012-1-git-send-email-jon.mason@broadcom.com> <1478030682-27012-3-git-send-email-jon.mason@broadcom.com> <20161101204826.GA21010@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161101204826.GA21010@lunn.ch> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 01, 2016 at 09:48:26PM +0100, Andrew Lunn wrote: > > +- enet-phy-lane-swap: If set, indicates the PHY device requires swapping the > > + TX/RX lanes to function properly. > > Is 'requires' the right word here? The PHY performs the actual swap of > the Tx/Rx lanes. What I'm trying to say here is that without the lane swapping, the PHY will not function properly. Thus, those PHYs require this parameter to work. I am open to suggestions to reword the sentence to make it clearer. Thanks, Jon > > Andrew