From: Brenden Blanco <bblanco@plumgrid.com>
To: Tariq Toukan <tariqt@mellanox.com>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, Eran Ben Elisha <eranbe@mellanox.com>,
Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Saeed Mahameed <saeedm@mellanox.com>
Subject: Re: [PATCH net-next V2 3/3] net/mlx4_en: Add ethtool statistics for XDP cases
Date: Tue, 1 Nov 2016 15:06:04 -0600 [thread overview]
Message-ID: <20161101210604.GA29427@gmail.com> (raw)
In-Reply-To: <1478000186-5158-4-git-send-email-tariqt@mellanox.com>
On Tue, Nov 01, 2016 at 01:36:26PM +0200, Tariq Toukan wrote:
> XDP statistics are reported in ethtool as follows:
> - xdp_drop: the number of packets dropped by xdp.
> - xdp_tx: the number of packets forwarded by xdp.
> - xdp_tx_full: the number of times an xdp forward failed
> due to a full tx xdp ring.
>
> In addition, all packets that are dropped/forwarded by XDP
> are no longer accounted in rx_packets/rx_bytes of the ring,
> so that they count traffic that is passed to the stack.
This seems like a step backwards, in that I now no longer have any
statistic whatsoever that can count xdp packets per-ring. For instance,
how would I validate that my flow-hash rules are operating correctly? I
would suggest to restore the rxN_packet/bytes stat increment.
>
> Signed-off-by: Tariq Toukan <tariqt@mellanox.com>
> ---
> drivers/net/ethernet/mellanox/mlx4/en_ethtool.c | 14 ++++++++++++++
> drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 4 ++++
> drivers/net/ethernet/mellanox/mlx4/en_port.c | 6 ++++++
> drivers/net/ethernet/mellanox/mlx4/en_rx.c | 12 +++++++-----
> drivers/net/ethernet/mellanox/mlx4/en_tx.c | 8 ++++----
> drivers/net/ethernet/mellanox/mlx4/mlx4_en.h | 7 ++++++-
> drivers/net/ethernet/mellanox/mlx4/mlx4_stats.h | 10 +++++++++-
> 7 files changed, 50 insertions(+), 11 deletions(-)
[...]
next prev parent reply other threads:[~2016-11-01 21:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-01 11:36 [PATCH net-next V2 0/3] mlx4 XDP TX refactor Tariq Toukan
2016-11-01 11:36 ` [PATCH net-next V2 1/3] net/mlx4_en: Add TX_XDP for CQ types Tariq Toukan
2016-11-01 11:57 ` Saeed Mahameed
2016-11-01 11:36 ` [PATCH net-next V2 2/3] net/mlx4_en: Refactor the XDP forwarding rings scheme Tariq Toukan
2016-11-01 11:57 ` Saeed Mahameed
2016-11-01 11:36 ` [PATCH net-next V2 3/3] net/mlx4_en: Add ethtool statistics for XDP cases Tariq Toukan
2016-11-01 11:57 ` Saeed Mahameed
2016-11-01 21:06 ` Brenden Blanco [this message]
2016-11-02 8:18 ` Tariq Toukan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161101210604.GA29427@gmail.com \
--to=bblanco@plumgrid.com \
--cc=alexei.starovoitov@gmail.com \
--cc=davem@davemloft.net \
--cc=eranbe@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
--cc=tariqt@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.