Re: [PATCH nf] netfilter: conntrack: refine gc worker heuristics

[Florian Westphal <fw@strlen.de>]

Eric Dumazet <eric.dumazet@gmail.com> wrote:
> On Tue, 2016-11-01 at 21:01 +0100, Florian Westphal wrote:
> >  	schedule_delayed_work(&gc_work->dwork, next_run);
> 
> 
> > @@ -993,6 +1029,7 @@ static void gc_worker(struct work_struct *work)
> >  static void conntrack_gc_work_init(struct conntrack_gc_work *gc_work)
> >  {
> >  	INIT_DELAYED_WORK(&gc_work->dwork, gc_worker);
> > +	gc_work->next_gc_run = GC_INTERVAL_MAX;
> >  	gc_work->exiting = false;
> >  }
> >  
> > @@ -1885,7 +1922,7 @@ int nf_conntrack_init_start(void)
> >  	nf_ct_untracked_status_or(IPS_CONFIRMED | IPS_UNTRACKED);
> >  
> >  	conntrack_gc_work_init(&conntrack_gc_work);
> > -	schedule_delayed_work(&conntrack_gc_work.dwork, GC_INTERVAL);
> > +	schedule_delayed_work(&conntrack_gc_work.dwork, GC_INTERVAL_MAX);
> >  
> >  	return 0;
> >  
> 
> 
> We might use system_long_wq instead of system_wq ?
> 
> queue_delayed_work(system_long_wq, ...)

Ok, I will change this for v2, thanks Eric.