From: Kevin Wolf <kwolf@redhat.com>
To: Ashijeet Acharya <ashijeetacharya@gmail.com>
Cc: mreitz@redhat.com, rjones@redhat.com, jcody@redhat.com,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] block/ssh: Fix the regression of unused parameter
Date: Wed, 2 Nov 2016 11:33:31 +0100 [thread overview]
Message-ID: <20161102103331.GC6182@noname.redhat.com> (raw)
In-Reply-To: <1477937214-20899-1-git-send-email-ashijeetacharya@gmail.com>
Am 31.10.2016 um 19:06 hat Ashijeet Acharya geschrieben:
> This patch drops the unused parameter "BDRVSSHState" being passed into
> the ssh_config() function and fixes the bug.
>
> Signed-off-by: Ashijeet Acharya <ashijeetacharya@gmail.com>
The patch looks good, but why do claim that this is a bug fix rather
than just a code cleanup?
Kevin
next prev parent reply other threads:[~2016-11-02 10:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-31 18:06 [Qemu-devel] [PATCH] block/ssh: Fix the regression of unused parameter Ashijeet Acharya
2016-11-02 10:33 ` Kevin Wolf [this message]
2016-11-02 10:35 ` Ashijeet Acharya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161102103331.GC6182@noname.redhat.com \
--to=kwolf@redhat.com \
--cc=ashijeetacharya@gmail.com \
--cc=jcody@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rjones@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.