Re: [PATCH 1/2] linearize: Emit C99 declarations correctly

[Luc Van Oostenryck <luc.vanoostenryck@gmail.com>]

On Wed, May 04, 2016 at 08:39:43AM -0400, Emily Maier wrote:
> Variables declared with C99 syntax inside a for statement should be
> linearized in the loop top, rather than implicitly inside the loop body.
> 
> Signed-off-by: Emily Maier <emily@emilymaier.net>
> ---
>  linearize.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/linearize.c b/linearize.c
> index c6ada1e..1309c7d 100644
> --- a/linearize.c
> +++ b/linearize.c
> @@ -1946,7 +1946,11 @@ static pseudo_t linearize_iterator(struct entrypoint *ep, struct statement *stmt
>  	struct statement  *post_statement = stmt->iterator_post_statement;
>  	struct expression *post_condition = stmt->iterator_post_condition;
>  	struct basic_block *loop_top, *loop_body, *loop_continue, *loop_end;
> +	struct symbol *sym;
>  
> +	FOR_EACH_PTR(stmt->iterator_syms, sym) {
> +		linearize_one_symbol(ep, sym);
> +	} END_FOR_EACH_PTR(sym);
>  	concat_symbol_list(stmt->iterator_syms, &ep->syms);
>  	linearize_statement(ep, pre_statement);
>  
> -- 

Interesting catch!

Reviewed-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Tested-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>