From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v3 4/5] llistxattr: new testcase for long path name
Date: Wed, 2 Nov 2016 16:47:31 +0100 [thread overview]
Message-ID: <20161102154731.GG28344@rei.lan> (raw)
In-Reply-To: <1478084391-30192-5-git-send-email-dejan.jovicevic@rt-rk.com>
> +char longpathname[PATH_MAX + 2];
Should be static char.
> static struct test_case {
> const char *path;
> size_t size;
> @@ -54,7 +58,8 @@ static struct test_case {
> } tc[] = {
> {SYMLINK, 1, ERANGE},
> {"", 20, ENOENT},
> - {(char *)-1, 20, EFAULT}
> + {(char *)-1, 20, EFAULT},
> + {longpathname, 20, ENAMETOOLONG}
> };
>
> static void verify_llistxattr(unsigned int n)
> @@ -85,6 +90,8 @@ static void setup(void)
> SAFE_SYMLINK(TESTFILE, SYMLINK);
>
> SAFE_LSETXATTR(SYMLINK, SECURITY_KEY, VALUE, VALUE_SIZE, XATTR_CREATE);
> +
> + memset(&longpathname, 'a', sizeof(longpathname) - 1);
No need for the & here (in C array is a pointer to a first member and
&array == array).
Otherwise it's fine.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2016-11-02 15:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-02 10:59 [LTP] [PATCH v3 0/5] Listxattr related calls: new tests and testcase Dejan Jovicevic
2016-11-02 10:59 ` [LTP] [PATCH v3 1/5] safe_macros: add safe_setxattr(), Dejan Jovicevic
2016-11-02 15:37 ` Cyril Hrubis
2016-11-02 10:59 ` [LTP] [PATCH v3 2/5] llistxattr: moved to using safe macros Dejan Jovicevic
2016-11-02 15:38 ` Cyril Hrubis
2016-11-02 10:59 ` [LTP] [PATCH v3 3/5] llistxattr: improved code readability and Dejan Jovicevic
2016-11-02 15:44 ` Cyril Hrubis
2016-11-02 10:59 ` [LTP] [PATCH v3 4/5] llistxattr: new testcase for long path name Dejan Jovicevic
2016-11-02 15:47 ` Cyril Hrubis [this message]
2016-11-02 10:59 ` [LTP] [PATCH v3 5/5] flistxattr and listxattr: added tests Dejan Jovicevic
2016-11-02 16:13 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161102154731.GG28344@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.