All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brian Norris <briannorris@chromium.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Pavel Machek <pavel@ucw.cz>, Len Brown <len.brown@intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org,
	Doug Anderson <dianders@chromium.org>,
	Brian Norris <computersforpeace@gmail.com>,
	Jeffy Chen <jeffy.chen@rock-chips.com>,
	linux-pm@vger.kernel.org,
	Chuansheng Liu <chuansheng.liu@intel.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>
Subject: Re: [RESEND PATCH 1/2] PM / sleep: print function name of callbacks
Date: Wed, 2 Nov 2016 14:02:17 -0700	[thread overview]
Message-ID: <20161102210216.GB27786@google.com> (raw)
In-Reply-To: <1739391.aWGq2sgtym@vostro.rjw.lan>

On Tue, Nov 01, 2016 at 05:27:05AM +0100, Rafael J. Wysocki wrote:
> Any reason why you need to rely on the initcall_debug stuff instead of using
> the tracepoints we have there (for exactly the reason why you are pushing this
> patch)?

This was mentioned on the last submission. I'll paste Doug's reply from
there:

"""
On Tue, Sep 22, 2015 at 10:33 AM, Brown, Len <len.brown@intel.com>
wrote:
> have you used analyze_suspend?
> It used to parse this output, but that was abandoned
> when it cut over to using ftrace directly.
>
> https://01.org/suspendresume

Ah, good to know about.  In my case this output is enabled on shipping
devices and sometimes we get back bug reports with these prints in the
log, so I'm interested in making the prints more useful.  :)

-Doug
"""

Perhaps I should have elabotated on the RESEND...

Or is there a really good way to make use of the tracepoints for
production systems, including for crash reports? We currently get the
kernel log from pstore, but I see ftrace support has been there for a
little while too. Still, it's awfully useful to have kernel prints and
warnings interleave with initcall_debug, and it wouldn't be quite as
easy to have to piece this together between kernel log + ftrace log.

Brian

      reply	other threads:[~2016-11-02 21:02 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-20  0:26 [RESEND PATCH 1/2] PM / sleep: print function name of callbacks Brian Norris
2016-10-20  0:26 ` Brian Norris
2016-10-20  0:26 ` [PATCH 2/2] PM / sleep: don't suspend parent when async child suspend_{noirq,early} fails Brian Norris
2016-10-20  0:26   ` Brian Norris
2016-10-20  0:46   ` Brian Norris
2016-10-27 15:34     ` Greg Kroah-Hartman
2016-10-27 16:03       ` Brian Norris
2016-10-20  0:56   ` Dmitry Torokhov
2016-10-27 16:05   ` [PATCH v2 2/2] PM / sleep: don't suspend parent when async child suspend_{noirq,late} fails Brian Norris
2016-10-27 16:05     ` Brian Norris
2016-11-01  4:25     ` Rafael J. Wysocki
2016-11-01  5:22       ` Brian Norris
2016-11-01  6:04       ` Dmitry Torokhov
2016-11-02  3:51         ` Rafael J. Wysocki
2016-11-02  5:07           ` Brian Norris
2016-11-10  0:08             ` Rafael J. Wysocki
2016-11-10  0:18               ` Brian Norris
2016-11-10  1:21     ` [PATCH v3] " Brian Norris
2016-11-10  1:21       ` Brian Norris
2016-11-10  1:53       ` Rafael J. Wysocki
2016-11-10  2:00         ` Brian Norris
2016-11-11  1:42           ` Rafael J. Wysocki
2016-10-20  0:52 ` [RESEND PATCH 1/2] PM / sleep: print function name of callbacks Dmitry Torokhov
2016-11-01  4:27 ` Rafael J. Wysocki
2016-11-02 21:02   ` Brian Norris [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161102210216.GB27786@google.com \
    --to=briannorris@chromium.org \
    --cc=chuansheng.liu@intel.com \
    --cc=computersforpeace@gmail.com \
    --cc=dianders@chromium.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jeffy.chen@rock-chips.com \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=rjw@rjwysocki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.