All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Max Reitz <mreitz@redhat.com>
Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org,
	Jeff Cody <jcody@redhat.com>,
	Markus Armbruster <armbru@redhat.com>,
	Eric Blake <eblake@redhat.com>
Subject: Re: [Qemu-devel] [PATCH for-2.8? 0/3] block/curl: Drop TFTP "support"
Date: Thu, 3 Nov 2016 10:42:49 +0100	[thread overview]
Message-ID: <20161103094249.GA5352@noname.redhat.com> (raw)
In-Reply-To: <20161102175539.4375-1-mreitz@redhat.com>

Am 02.11.2016 um 18:55 hat Max Reitz geschrieben:
> See patch 3 for the reason why we have actually never supported TFTP at
> all (except for very small files (i.e. below 256 kB or so)).
> 
> I would consider this series a bug fix because, well, it doesn't really
> change any functionality, and the bug is "We don't support TFTP but we
> pretend we do".

Reviewed-by: Kevin Wolf <kwolf@redhat.com>

libvirt added support for tftp in commit 8ffe1d0c, in a series that
added https and ftps, too. I suppose tftp wasn't actually tested. Maybe
libvirt wants to remove tftp as well.

Kevin

  parent reply	other threads:[~2016-11-03  9:43 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-02 17:55 [Qemu-devel] [PATCH for-2.8? 0/3] block/curl: Drop TFTP "support" Max Reitz
2016-11-02 17:55 ` [Qemu-devel] [PATCH for-2.8? 1/3] qemu-options: Drop mentions of curl's TFTP support Max Reitz
2016-11-02 18:20   ` Jeff Cody
2016-11-02 17:55 ` [Qemu-devel] [PATCH for-2.8? 2/3] qapi: Drop curl's TFTP protocol Max Reitz
2016-11-02 18:22   ` Jeff Cody
2016-11-02 17:55 ` [Qemu-devel] [PATCH for-2.8? 3/3] block/curl: Drop TFTP "support" Max Reitz
2016-11-02 18:22   ` Jeff Cody
2016-11-02 18:20 ` [Qemu-devel] [PATCH for-2.8? 0/3] " Jeff Cody
2016-11-03  7:56 ` Markus Armbruster
2016-11-04 16:53   ` Max Reitz
2016-11-07  8:20     ` Markus Armbruster
2016-11-07 15:42       ` Max Reitz
2016-11-08  7:14         ` Markus Armbruster
2016-11-09 19:15           ` Jeff Cody
2016-11-11 19:46             ` Max Reitz
2016-11-14 18:54               ` Jeff Cody
2016-11-03  9:42 ` Kevin Wolf [this message]
2016-11-07 12:57 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161103094249.GA5352@noname.redhat.com \
    --to=kwolf@redhat.com \
    --cc=armbru@redhat.com \
    --cc=eblake@redhat.com \
    --cc=jcody@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.