Re: [PATCH 4/7] resize.f2fs: get latest free segments

[Jaegeuk Kim <jaegeuk@kernel.org>]

On Thu, Nov 03, 2016 at 02:53:20PM +0800, heyunlei wrote:
> 
> Hi, Kim
> On 2016/11/3 13:28, Jaegeuk Kim wrote:
> > The # of free segments can be changed by defragmentation.
> > 
> > Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> > ---
> >  fsck/resize.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/fsck/resize.c b/fsck/resize.c
> > index 5dc73a8..4813de7 100644
> > --- a/fsck/resize.c
> > +++ b/fsck/resize.c
> > @@ -424,7 +424,7 @@ static void rebuild_checkpoint(struct f2fs_sb_info *sbi,
> >  	set_cp(overprov_segment_count, get_cp(overprov_segment_count) +
> >  						get_cp(rsvd_segment_count));
> > 
> > -	free_segment_count = get_cp(free_segment_count);
> > +	free_segment_count = get_free_segments(sbi);
> 
> f2fs_defragment will write a checkpoint and then update free_segment_count
> by get_free_segments(sbi)o<\f
 Is it righto<\x1f

In f2fs_defragment(),
 - flush_journal_entries()
 - migrate_blocks()
 - move_curseg_info()
 - zero-journal_entries()
 - write_curseg_info()
 - flush_sit_entries()
 - write_checkpoint()
   - free_segment_count = get_free_segments()
   - write cp pack

Since I can't catch your point, could you please explain in more detail?

> 
> Thankso<\f

> >  	new_segment_count = get_newsb(segment_count_main) -
> >  					get_sb(segment_count_main);
> > 
> > 

------------------------------------------------------------------------------
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today. http://sdm.link/xeonphi