From: "Linus Lüssing" <linus.luessing@c0d3.blue>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Cc: julian@freifunk-rtk.de
Subject: Re: [B.A.T.M.A.N.] [PATCH maint] batman-adv: Revert "fix splat on disabling an interface"
Date: Fri, 4 Nov 2016 04:42:07 +0100 [thread overview]
Message-ID: <20161104034207.GD4490@otheros> (raw)
In-Reply-To: <20161102171443.9491-1-sven@narfation.org>
On Wed, Nov 02, 2016 at 06:14:43PM +0100, Sven Eckelmann wrote:
> The commit bac7733d06fa ("batman-adv: fix splat on disabling an interface")
> fixed a warning but at the same time broke the rtnl function add_slave for
> devices which were temporarily removed.
>
> batadv_softif_slave_add requires soft_iface of and hard_iface to be NULL
> before it is allowed to be enslaved. But this resetting of soft_iface to
> NULL in batadv_hardif_disable_interface was removed with the aforementioned
> commit.
>
> Reported-by: Julian Labus <julian@freifunk-rtk.de>
> Signed-off-by: Sven Eckelmann <sven@narfation.org>
> Cc: Linus Lüssing <linus.luessing@c0d3.blue>
> ---
Like I said in the ticket, I can't reproduce the splat with
v2016.4 plus this revert right now.
Maybe changes to the hard-interface handling might have fixed it
properly in the mean time.
Acked-by: Linus Lüssing <linus.luessing@c0d3.blue>
next prev parent reply other threads:[~2016-11-04 3:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-02 17:14 [B.A.T.M.A.N.] [PATCH maint] batman-adv: Revert "fix splat on disabling an interface" Sven Eckelmann
2016-11-04 3:42 ` Linus Lüssing [this message]
2016-11-04 7:16 ` [B.A.T.M.A.N.] [maint] " Sven Eckelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161104034207.GD4490@otheros \
--to=linus.luessing@c0d3.blue \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=julian@freifunk-rtk.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.