From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Sakkinen Subject: Re: [PATCH 1/2] tpm/tpm-interface: place kdoc just above tpm_pcr_extend Date: Thu, 3 Nov 2016 23:22:31 -0600 Message-ID: <20161104052231.kwclspdmpyml7alt@intel.com> References: <1477962314-26763-1-git-send-email-tomas.winkler@intel.com> <1477962314-26763-2-git-send-email-tomas.winkler@intel.com> <20161102100220.v2nlbf767sticcp7@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20161102100220.v2nlbf767sticcp7-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Tomas Winkler Cc: tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: tpmdd-devel@lists.sourceforge.net On Wed, Nov 02, 2016 at 04:02:20AM -0600, Jarkko Sakkinen wrote: > On Tue, Nov 01, 2016 at 03:05:13AM +0200, Tomas Winkler wrote: > > Place kdoc just above tpm_pcr_extend so it can be parsed > > correctly. > > > > Signed-off-by: Tomas Winkler > > Reviewed-by: Jarkko Sakkinen I applied this although I edited the short description (stripped away "/tpm-interface". /Jarkko > > /Jarkko > > > --- > > drivers/char/tpm/tpm-interface.c | 16 ++++++++-------- > > 1 file changed, 8 insertions(+), 8 deletions(-) > > > > diff --git a/drivers/char/tpm/tpm-interface.c b/drivers/char/tpm/tpm-interface.c > > index cb0e57ee053d..d496a6b26a45 100644 > > --- a/drivers/char/tpm/tpm-interface.c > > +++ b/drivers/char/tpm/tpm-interface.c > > @@ -731,6 +731,14 @@ int tpm_pcr_read(u32 chip_num, int pcr_idx, u8 *res_buf) > > } > > EXPORT_SYMBOL_GPL(tpm_pcr_read); > > > > +#define TPM_ORD_PCR_EXTEND cpu_to_be32(20) > > +#define EXTEND_PCR_RESULT_SIZE 34 > > +static const struct tpm_input_header pcrextend_header = { > > + .tag = TPM_TAG_RQU_COMMAND, > > + .length = cpu_to_be32(34), > > + .ordinal = TPM_ORD_PCR_EXTEND > > +}; > > + > > /** > > * tpm_pcr_extend - extend pcr value with hash > > * @chip_num: tpm idx # or AN& > > @@ -741,14 +749,6 @@ EXPORT_SYMBOL_GPL(tpm_pcr_read); > > * isn't, protect against the chip disappearing, by incrementing > > * the module usage count. > > */ > > -#define TPM_ORD_PCR_EXTEND cpu_to_be32(20) > > -#define EXTEND_PCR_RESULT_SIZE 34 > > -static const struct tpm_input_header pcrextend_header = { > > - .tag = TPM_TAG_RQU_COMMAND, > > - .length = cpu_to_be32(34), > > - .ordinal = TPM_ORD_PCR_EXTEND > > -}; > > - > > int tpm_pcr_extend(u32 chip_num, int pcr_idx, const u8 *hash) > > { > > struct tpm_cmd_t cmd; > > -- > > 2.7.4 > > ------------------------------------------------------------------------------ Developer Access Program for Intel Xeon Phi Processors Access to Intel Xeon Phi processor-based developer platforms. With one year of Intel Parallel Studio XE. Training and support from Colfax. Order your platform today. http://sdm.link/xeonphi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759781AbcKDFWh (ORCPT ); Fri, 4 Nov 2016 01:22:37 -0400 Received: from mga07.intel.com ([134.134.136.100]:13062 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756085AbcKDFWg (ORCPT ); Fri, 4 Nov 2016 01:22:36 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,442,1473145200"; d="scan'208";a="187482203" Date: Thu, 3 Nov 2016 23:22:31 -0600 From: Jarkko Sakkinen To: Tomas Winkler Cc: tpmdd-devel@lists.sourceforge.net, Jason Gunthorpe , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] tpm/tpm-interface: place kdoc just above tpm_pcr_extend Message-ID: <20161104052231.kwclspdmpyml7alt@intel.com> References: <1477962314-26763-1-git-send-email-tomas.winkler@intel.com> <1477962314-26763-2-git-send-email-tomas.winkler@intel.com> <20161102100220.v2nlbf767sticcp7@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161102100220.v2nlbf767sticcp7@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 02, 2016 at 04:02:20AM -0600, Jarkko Sakkinen wrote: > On Tue, Nov 01, 2016 at 03:05:13AM +0200, Tomas Winkler wrote: > > Place kdoc just above tpm_pcr_extend so it can be parsed > > correctly. > > > > Signed-off-by: Tomas Winkler > > Reviewed-by: Jarkko Sakkinen I applied this although I edited the short description (stripped away "/tpm-interface". /Jarkko > > /Jarkko > > > --- > > drivers/char/tpm/tpm-interface.c | 16 ++++++++-------- > > 1 file changed, 8 insertions(+), 8 deletions(-) > > > > diff --git a/drivers/char/tpm/tpm-interface.c b/drivers/char/tpm/tpm-interface.c > > index cb0e57ee053d..d496a6b26a45 100644 > > --- a/drivers/char/tpm/tpm-interface.c > > +++ b/drivers/char/tpm/tpm-interface.c > > @@ -731,6 +731,14 @@ int tpm_pcr_read(u32 chip_num, int pcr_idx, u8 *res_buf) > > } > > EXPORT_SYMBOL_GPL(tpm_pcr_read); > > > > +#define TPM_ORD_PCR_EXTEND cpu_to_be32(20) > > +#define EXTEND_PCR_RESULT_SIZE 34 > > +static const struct tpm_input_header pcrextend_header = { > > + .tag = TPM_TAG_RQU_COMMAND, > > + .length = cpu_to_be32(34), > > + .ordinal = TPM_ORD_PCR_EXTEND > > +}; > > + > > /** > > * tpm_pcr_extend - extend pcr value with hash > > * @chip_num: tpm idx # or AN& > > @@ -741,14 +749,6 @@ EXPORT_SYMBOL_GPL(tpm_pcr_read); > > * isn't, protect against the chip disappearing, by incrementing > > * the module usage count. > > */ > > -#define TPM_ORD_PCR_EXTEND cpu_to_be32(20) > > -#define EXTEND_PCR_RESULT_SIZE 34 > > -static const struct tpm_input_header pcrextend_header = { > > - .tag = TPM_TAG_RQU_COMMAND, > > - .length = cpu_to_be32(34), > > - .ordinal = TPM_ORD_PCR_EXTEND > > -}; > > - > > int tpm_pcr_extend(u32 chip_num, int pcr_idx, const u8 *hash) > > { > > struct tpm_cmd_t cmd; > > -- > > 2.7.4 > >