From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roger Pau Monne Subject: Re: [PATCH v3.1 08/15] x86/vtd: fix mapping of RMRR regions Date: Fri, 4 Nov 2016 10:45:10 +0100 Message-ID: <20161104094510.23gluwhs22uvtei5@mac> References: <1477731601-10926-1-git-send-email-roger.pau@citrix.com> <1477731601-10926-9-git-send-email-roger.pau@citrix.com> <581C600F020000780011C313@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c2b3n-0007er-6x for xen-devel@lists.xenproject.org; Fri, 04 Nov 2016 09:45:19 +0000 Content-Disposition: inline In-Reply-To: <581C600F020000780011C313@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Jan Beulich Cc: George Dunlap , Andrew Cooper , boris.ostrovsky@oracle.com, xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org T24gRnJpLCBOb3YgMDQsIDIwMTYgYXQgMDM6MTY6NDdBTSAtMDYwMCwgSmFuIEJldWxpY2ggd3Jv dGU6Cj4gPj4+IE9uIDI5LjEwLjE2IGF0IDEwOjU5LCA8cm9nZXIucGF1QGNpdHJpeC5jb20+IHdy b3RlOgo+ID4gLS0tIGEveGVuL2FyY2gveDg2L21tL3AybS5jCj4gPiArKysgYi94ZW4vYXJjaC94 ODYvbW0vcDJtLmMKPiA+IEBAIC0xMDQ5LDIyICsxMDQ5LDI5IEBAIGludCBzZXRfaWRlbnRpdHlf cDJtX2VudHJ5KHN0cnVjdCBkb21haW4gKmQsIHVuc2lnbmVkIGxvbmcgZ2ZuLAo+ID4gIAo+ID4g ICAgICBtZm4gPSBwMm0tPmdldF9lbnRyeShwMm0sIGdmbiwgJnAybXQsICZhLCAwLCBOVUxMLCBO VUxMKTsKPiA+ICAKPiA+IC0gICAgaWYgKCBwMm10ID09IHAybV9pbnZhbGlkIHx8IHAybXQgPT0g cDJtX21taW9fZG0gKQo+ID4gKyAgICBzd2l0Y2ggKCBwMm10ICkKPiA+ICsgICAgewo+ID4gKyAg ICBjYXNlIHAybV9pbnZhbGlkOgo+ID4gKyAgICBjYXNlIHAybV9tbWlvX2RtOgo+ID4gICAgICAg ICAgcmV0ID0gcDJtX3NldF9lbnRyeShwMm0sIGdmbiwgX21mbihnZm4pLCBQQUdFX09SREVSXzRL LAo+ID4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwMm1fbW1pb19kaXJlY3QsIHAybWEp Owo+ID4gLSAgICBlbHNlIGlmICggbWZuX3gobWZuKSA9PSBnZm4gJiYgcDJtdCA9PSBwMm1fbW1p b19kaXJlY3QgJiYgYSA9PSBwMm1hICkKPiA+IC0gICAgewo+ID4gLSAgICAgICAgcmV0ID0gMDsK PiA+IC0gICAgICAgIC8qCj4gPiAtICAgICAgICAgKiBQVkggZml4bWU6IGR1cmluZyBEb20wIFBW SCBjb25zdHJ1Y3Rpb24sIHAybSBlbnRyaWVzIGFyZSBiZWluZyBzZXQKPiA+IC0gICAgICAgICAq IGJ1dCBpb21lbSByZWdpb25zIGFyZSBub3QgbWFwcGVkIHdpdGggSU9NTVUuIFRoaXMgbWFrZXMg c3VyZSB0aGF0Cj4gPiAtICAgICAgICAgKiBSTVJScyBhcmUgY29ycmVjdGx5IG1hcHBlZCB3aXRo IElPTU1VLgo+ID4gLSAgICAgICAgICovCj4gPiAtICAgICAgICBpZiAoIGlzX2hhcmR3YXJlX2Rv bWFpbihkKSAmJiAhaW9tbXVfdXNlX2hhcF9wdChkKSApCj4gPiArICAgICAgICBpZiAoIHJldCAp Cj4gPiArICAgICAgICAgICAgYnJlYWs7Cj4gPiArICAgICAgICAvKiBmYWxsdGhyb3VnaCAqLwo+ ID4gKyAgICBjYXNlIHAybV9tbWlvX2RpcmVjdDoKPiA+ICsgICAgICAgIGlmICggcDJtdCA9PSBw Mm1fbW1pb19kaXJlY3QgJiYgYSAhPSBwMm1hICkKPiAKPiBJIGRvbid0IHVuZGVyc3RhbmQgdGhl IHJlbW92YWwgb2YgdGhlIE1GTiA9PSBHRk4gY2hlY2ssIGFuZCBpdAo+IGFsc28gaXNuJ3QgYmVp bmcgZXhwbGFpbmVkIGluIHRoZSBjb21taXQgbWVzc2FnZS4KCk1heWJlIEknbSBub3QgdW5kZXJz dGFuZGluZyB0aGUgbG9naWMgb2YgdGhpcyBmdW5jdGlvbiBjb3JyZWN0bHksIGJ1dCBpdCAKc2Vl bXMgZXh0cmVtZWx5IGJvZ3VzLCBhbmQgYmVoYXZlcyBxdWl0ZSBkaWZmZXJlbnRseSBkZXBlbmRp bmcgb24gd2hldGhlciAKZ2ZuID09IG1mbiBhbmQgd2hldGhlciB0aGUgZG9tYWluIGlzIHRoZSBo YXJkd2FyZSBkb21haW4uCgpJZiBnZm4gPT0gbWZuIChzbyB0aGUgcGFnZSBpcyBhbHJlYWR5IG1h cHBlZCBpbiB0aGUgcDJtKSBhbmQgdGhlIGRvbWFpbiBpcyAKdGhlIGhhcmR3YXJlIGRvbWFpbiwg YW4gSU9NTVUgbWFwcGluZyB3b3VsZCBiZSBlc3RhYmxpc2hlZC4gSWYgZ2ZuIGlzIG5vdCAKc2V0 LCB3ZSB3aWxsIGp1c3Qgc2V0IHRoZSBwMm0gZW50cnksIGJ1dCB0aGUgSU9NTVUgaXMgbm90IGdv aW5nIHRvIGJlIApwcm9wZXJseSBjb25maWd1cmVkLCB1bmxlc3MgaXQgc2hhcmVzIHRoZSBwdCB3 aXRoIHAybS4KClRoaXMgcGF0Y2ggZml4ZXMgdGhlIGJlaGF2aW9yIG9mIHRoZSBmdW5jdGlvbiBz byBpdCdzIGNvbnNpc3RlbnQsIGFuZCB3ZSAKY2FuIGd1YXJhbnRlZSB0aGF0IGFmdGVyIGNhbGxp bmcgaXQgYSBwcm9wZXIgbWFwcGluZyBpbiB0aGUgcDJtIGFuZCB0aGUgSU9NTVUgCndpbGwgZXhp c3QsIGFuZCB0aGF0IGl0J3MgZ29pbmcgdG8gYmUgZ2ZuID09IG1mbiwgb3IgZWxzZSBhbiBlcnJv ciB3aWxsIGJlIApyZXR1cm5lZC4KCkkgYWdyZWUgd2l0aCB5b3UgdGhhdCB0aGUgbWZuID09IGdm biBjaGVjayBzaG91bGQgYmUga2VwdCwgc28gdGhlIGNvbmRpdGlvbiAKYWJvdmUgc2hvdWxkIGJl OgoKCWlmICggcDJtdCA9PSBwMm1fbW1pb19kaXJlY3QgJiYgKGEgIT0gcDJtYSB8fMKgZ2ZuICE9 IG1mbikgKQoKQnV0IHBsZWFzZSBzZWUgYmVsb3cuCgo+IEFuZCB0aGVuIGZvbGxvd2luZyBhIGNh c2UgbGFiZWwgd2l0aCBhIGNvbXBhcmlzb24gb2YgdGhlIHJlc3BlY3RpdmUKPiBzd2l0Y2ggZXhw cmVzc2lvbiBhZ2FpbnN0IHRoZSB2ZXJ5IHZhbHVlIGZyb20gdGhlIGNhc2UgbGFiZWwgaXMKPiBj ZXJ0YWlubHkgb2RkLiBJJ20gcHJldHR5IHN1cmUgYSBiZXR0ZXIgc3RydWN0dXJlIG9mIHRoZSBj b2RlIGNvdWxkIGJlCj4gZm91bmQuCgpIbSwgdGhlIGNvbXBhcmlzb24gaXMgdGhlcmUgYmVjYXVz ZSBvZiB0aGUgZmFsbHRocm91Z2ggaW4gdGhlIGFib3ZlIGNhc2UuIEkgCmNvdWxkIHJlbW92ZSBp dCBieSBhbHNvIHNldHRpbmcgdGhlIElPTU1VIGVudHJ5IGluIHRoZSBhYm92ZSBjYXNlLCBpZiB0 aGF0J3MgCmJldHRlciwgc28gaXQgd291bGQgbG9vayBsaWtlOgoKY2FzZSBwMm1faW52YWxpZDoK Y2FzZSBwMm1fbW1pb19kbToKICAgIHJldCA9IHAybV9zZXRfZW50cnkocDJtLCBnZm4sIF9tZm4o Z2ZuKSwgUEFHRV9PUkRFUl80SywKICAgICAgICAgICAgICAgICAgICAgICAgcDJtX21taW9fZGly ZWN0LCBwMm1hKTsKICAgIGlmICggcmV0ICkKICAgICAgICBicmVhazsKICAgIGlmICggIWlvbW11 X3VzZV9oYXBfcHQoZCkgKQogICAgICAgIHJldCA9IGlvbW11X21hcF9wYWdlKGQsIGdmbiwgZ2Zu LCBJT01NVUZfcmVhZGFibGV8SU9NTVVGX3dyaXRhYmxlKTsKICAgIGJyZWFrOwpjYXNlIHAybV9t bWlvX2RpcmVjdDoKICAgIGlmICggYSAhPSBwMm1hIHx8IGdmbiAhPSBtZm4gKQogICAgewogICAg ICAgIHByaW50ayhYRU5MT0dfR19XQVJOSU5HCiAgICAgICAgICAgICAgICJDYW5ub3Qgc2V0dXAg aWRlbnRpdHkgbWFwIGQlZDolbHgsIGFscmVhZHkgbWFwcGVkIHdpdGggIgogICAgICAgICAgICAg ICAiZGlmZmVyZW50IGFjY2VzcyB0eXBlIG9yIG1mblxuIiwgZC0+ZG9tYWluX2lkLCBnZm4pOwog ICAgICAgIHJldCA9IChmbGFnICYgWEVOX0RPTUNUTF9ERVZfUkRNX1JFTEFYRUQpID8gMCA6IC1F QlVTWTsKICAgICAgICBicmVhazsKICAgIH0KICAgIGlmICggIWlvbW11X3VzZV9oYXBfcHQoZCkg KQogICAgICAgIHJldCA9IGlvbW11X21hcF9wYWdlKGQsIGdmbiwgZ2ZuLCBJT01NVUZfcmVhZGFi bGV8SU9NTVVGX3dyaXRhYmxlKTsKICAgIGJyZWFrOwoKT3IgSSBjb3VsZCBhZGQgYW4gaWYgYmVm b3JlIGVudGVyaW5nIHRoZSBzd2l0Y2ggY2FzZSB0aGF0IGNoZWNrcyBpZiB0eXBlIGlzCnAybV9t bWlvX2RpcmVjdCBhbmQgaWYgdGhlIGFjY2VzcyB0eXBlIGFuZCBtZm4gbWF0Y2hlcyB3aGF0IHdl IGV4cGVjdCwgYnV0IEkgCnRoaW5rIHRoYXQncyBub3QgZ29pbmcgdG8gbWFrZSB0aGUgY29kZSBl YXNpZXIuCgo+ID4gKyAgICAgICAgewo+ID4gKyAgICAgICAgICAgIHByaW50ayhYRU5MT0dfR19X QVJOSU5HCj4gPiArICAgICAgICAgICAgICAgICAgICJDYW5ub3Qgc2V0dXAgaWRlbnRpdHkgbWFw IGQlZDolbHgsIGFscmVhZHkgbWFwcGVkIHdpdGggIgo+ID4gKyAgICAgICAgICAgICAgICAgICAi ZGlmZmVyZW50IGFjY2VzcyB0eXBlIChjdXJyZW50OiAlZCwgcmVxdWVzdGVkOiAlZCkuXG4iLAo+ IAo+IFBsZWFzZSBhdm9pZCBmdWxsIHN0b3BzIGF0IHRoZSBlbmQgb2YgbG9nIG1lc3NhZ2VzLgoK RG9uZS4KClRoYW5rcywgUm9nZXIuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW4u b3JnCmh0dHBzOi8vbGlzdHMueGVuLm9yZy94ZW4tZGV2ZWwK