From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ladislav Michl Subject: Re: [PATCH 0/2] musb-fixes for v4.9-rc2 Date: Fri, 4 Nov 2016 11:03:39 +0100 Message-ID: <20161104100339.GA27384@localhost.localdomain> References: <1476896620-15432-1-git-send-email-b-liu@ti.com> <20161020082318.GA2903@localhost.localdomain> <20161020123524.oepmqvlhzzu7elgj@atomide.com> <20161020193612.GA29736@localhost.localdomain> <20161021071722.2cetd2mt23t245ao@atomide.com> <20161024180708.kpx6s2jb7dpg6xfx@atomide.com> <20161101211358.GA2597@localhost.localdomain> <20161103205902.GB21430@atomide.com> <87r36rk5n9.fsf@linux.intel.com> <20161104094624.GA19642@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20161104094624.GA19642-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Felipe Balbi Cc: Tony Lindgren , Bin Liu , linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Kishon Vijay Abraham I List-Id: linux-omap@vger.kernel.org On Fri, Nov 04, 2016 at 10:46:24AM +0100, Ladislav Michl wrote: > On Fri, Nov 04, 2016 at 10:31:38AM +0200, Felipe Balbi wrote: > [snip] > > Sounds like VBUS dropping to me. Remember, MUSB is really anal about > > VBUS levels. If it drops enough for the PHY to report one of those 4 > > VBUS levels, then MUSB just gives up. > > > > What we used to do back at Nokia was disable reporting of some of those > > VBUS levels at the PHY driver. > > Well, I was getting these even without anything connected to musb: > [ 1526.594696] musb-hdrc musb-hdrc.0.auto: VBUS_ERROR in a_idle (90, [ 485.244781] musb-hdrc musb-hdrc.0.auto: VBUS_ERROR in a_idle (90, ...and with the hub connected: > [ 562.803833] musb-hdrc musb-hdrc.0.auto: VBUS_ERROR in a_idle (90, [ 50.068664] musb-hdrc musb-hdrc.0.auto: VBUS_ERROR in a_idle (90, And indeed, after these errors musb gives up. > > However these are gone with Tony's last patch. Bisecting now, approx 6 iterations left. So here we are: 87326e858448c40e32f142c0b8dcc59d7b27c641 is the first bad commit commit 87326e858448c40e32f142c0b8dcc59d7b27c641 Author: Tony Lindgren Date: Tue May 31 10:05:20 2016 -0500 usb: musb: Remove extra PM runtime calls from 2430 glue layer With PM runtime behaving, these are all now unnecessary. Doing pm_runtime_get(musb->controller) will keep the parent glue layer also active. Signed-off-by: Tony Lindgren Signed-off-by: Bin Liu Signed-off-by: Greg Kroah-Hartman :040000 040000 6b7553722d760982d40a3e211bca7595ff313c62 d007f683d33e61a9f0046661097849c976169670 M drivers -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html