All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/4] board: atmel: genimage: add 1M offset for FAT partition
Date: Fri, 4 Nov 2016 11:47:10 +0100	[thread overview]
Message-ID: <20161104114710.10ff39e6@free-electrons.com> (raw)
In-Reply-To: <20161104101517.7811-1-ludovic.desroches@atmel.com>

Hello,

On Fri, 4 Nov 2016 11:15:17 +0100, Ludovic Desroches wrote:
> With older SoCs and some SD cards, a 1024-bytes offset is needed to allow
> ROM code to read the content of the FAT partition. As it is usual to get
> a 1M bytes offset for the first partition, use this value to avoid boot
> issues.
> 
> Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>
> ---
>  board/atmel/at91sam9x5ek_mmc/genimage.cfg     | 1 +
>  board/atmel/sama5d2_xplained_mmc/genimage.cfg | 1 +
>  board/atmel/sama5d3_xplained_mmc/genimage.cfg | 1 +
>  board/atmel/sama5d4_xplained_mmc/genimage.cfg | 1 +
>  4 files changed, 4 insertions(+)

I've applied to master, after removing the hunk changing
board/atmel/at91sam9x5ek_mmc/genimage.cfg. Indeed, this file doesn't
exist in master since I haven't committed your PATCH 1/4. It is indeed
weird to:

 1/ Have patches making fixes *after* patches adding new features in a
    patch series. It should be the other way around.

 2/ In PATCH 1/4, introduce a genimage.cfg file for the
    at91sam9x5ek_mmc configuration that is wrong, and gets fixed in
    PATCH 2/4.

Anyway, this one is applied to master for SAMA5D{2,3,4}, we will handle
9x5EK separately.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2016-11-04 10:47 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-03 14:08 [Buildroot] [PATCH 1/4] configs: at91sam9x5ek: add development rootfs Ludovic Desroches
2016-11-03 14:08 ` [Buildroot] [PATCH 2/4] board: atmel: genimage: add 1M offset for FAT partition Ludovic Desroches
2016-11-03 14:20   ` Thomas Petazzoni
2016-11-04 10:15     ` Ludovic Desroches
2016-11-04 10:47       ` Thomas Petazzoni [this message]
2016-11-04 13:01         ` Ludovic Desroches
2016-11-03 14:08 ` [Buildroot] [PATCH 3/4] configs: atmel: xplained boards: bump to linux4sam_5.5 Ludovic Desroches
2016-11-03 21:40   ` Thomas Petazzoni
2016-11-03 14:08 ` [Buildroot] [PATCH 4/4] configs: atmel: at91sam9x5ek: " Ludovic Desroches
2016-11-03 21:40   ` Thomas Petazzoni
2016-11-04 10:48 ` [Buildroot] [PATCH 1/4] configs: at91sam9x5ek: add development rootfs Thomas Petazzoni
2016-11-04 13:14   ` Ludovic Desroches
2016-11-04 13:37     ` Alexandre Belloni
2016-11-04 13:53     ` Thomas Petazzoni
2016-11-04 16:28       ` Ludovic Desroches
2017-03-07 20:59 ` Thomas Petazzoni
2017-03-08  7:22   ` Ludovic Desroches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161104114710.10ff39e6@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.