From: Andrew Lunn <andrew@lunn.ch>
To: "Allan W. Nielsen" <allan.nielsen@microsemi.com>
Cc: netdev@vger.kernel.org, f.fainelli@gmail.com,
raju.lakkaraju@microsemi.com, cphealy@gmail.com, robh@kernel.org
Subject: Re: [PATCH net-next 1/5] ethtool: (uapi) Add ETHTOOL_PHY_GTUNABLE and ETHTOOL_PHY_STUNABLE
Date: Fri, 4 Nov 2016 13:29:35 +0100 [thread overview]
Message-ID: <20161104122935.GL13959@lunn.ch> (raw)
In-Reply-To: <20161104121841.GA5676@microsemi.com>
> It was "just" to mimic how "tunable_type_id/ETHTOOL_TUNABLE_UNSPEC" (and other)
> is done.
Yes, i know. I'm wondering about cult cargo programming...
> The thinking was that we did not want an "ID" of zero do to anything - because
> that could mean the programmer had forgot to set the field...
Seems reasonable. Leave it as is.
Andrew
next prev parent reply other threads:[~2016-11-04 12:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-04 10:35 [PATCH net-next 0/5] Adding PHY-Tunables and downshift support Allan W. Nielsen
2016-11-04 10:35 ` [PATCH net-next 1/5] ethtool: (uapi) Add ETHTOOL_PHY_GTUNABLE and ETHTOOL_PHY_STUNABLE Allan W. Nielsen
2016-11-04 12:03 ` Andrew Lunn
2016-11-04 12:18 ` Allan W. Nielsen
2016-11-04 12:29 ` Andrew Lunn [this message]
2016-11-04 10:35 ` [PATCH net-next 2/5] ethtool: Implements ETHTOOL_PHY_GTUNABLE/ETHTOOL_PHY_STUNABLE Allan W. Nielsen
2016-11-04 12:13 ` Andrew Lunn
2016-11-04 13:31 ` Allan W. Nielsen
2016-11-04 10:35 ` [PATCH net-next 3/5] ethtool: (uapi) Add ETHTOOL_PHY_DOWNSHIFT to PHY tunables Allan W. Nielsen
2016-11-04 10:35 ` [PATCH net-next 4/5] ethtool: Core impl for ETHTOOL_PHY_DOWNSHIFT tunable Allan W. Nielsen
2016-11-04 10:35 ` [PATCH net-next 5/5] net: phy: Add downshift get/set support in Microsemi PHYs driver Allan W. Nielsen
2016-11-04 12:27 ` Andrew Lunn
2016-11-04 13:42 ` Allan W. Nielsen
2016-11-04 13:55 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161104122935.GL13959@lunn.ch \
--to=andrew@lunn.ch \
--cc=allan.nielsen@microsemi.com \
--cc=cphealy@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=raju.lakkaraju@microsemi.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.