From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@fb.com>
Cc: axboe@kernel.dk, linux-kernel@vger.kernel.org,
linux-block@vger.kernel.org, hch@lst.de
Subject: Re: [PATCH 3/5] block: move poll code to blk-mq
Date: Fri, 4 Nov 2016 15:44:10 +0100 [thread overview]
Message-ID: <20161104144410.GA29203@lst.de> (raw)
In-Reply-To: <1478202307-1947-4-git-send-email-axboe@fb.com>
On Thu, Nov 03, 2016 at 01:45:05PM -0600, Jens Axboe wrote:
> The poll code is blk-mq specific, let's move it to blk-mq.c. This
> is a prep patch for improving the polling code.
>
> Signed-off-by: Jens Axboe <axboe@fb.com>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
So I gave my ok earlier, but I spent some more time looking at this
this morning and now I wonder why we even bother to keep some
code in blk-core.c. How about just renaming the whole damn thing
to blk_mq_poll and move it to blk-mq.c instead of that split?
next prev parent reply other threads:[~2016-11-04 14:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-03 19:45 [PATCHSET v2] block: IO polling improvements Jens Axboe
2016-11-03 19:45 ` [PATCH 1/5] block: fast-path for small and simple direct I/O requests Jens Axboe
2016-11-03 19:45 ` [PATCH 2/5] block: add scalable completion tracking of requests Jens Axboe
2016-11-03 19:45 ` [PATCH 3/5] block: move poll code to blk-mq Jens Axboe
2016-11-04 14:44 ` Christoph Hellwig [this message]
2016-11-04 15:30 ` Jens Axboe
2016-11-04 15:30 ` Jens Axboe
2016-11-03 19:45 ` [PATCH 4/5] blk-mq: implement hybrid poll mode for sync O_DIRECT Jens Axboe
2016-11-03 19:45 ` [PATCH 5/5] blk-mq: make the polling code adaptive Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161104144410.GA29203@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.