From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [QEMU PATCH] kvmclock: advance clock by time window between vm_stop and pre_save Date: Fri, 4 Nov 2016 15:07:52 -0200 Message-ID: <20161104170750.GA4346@amt.cnet> References: <20161104094322.GA16930@amt.cnet> <20161104152522.GC5388@potion> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: kvm@vger.kernel.org, qemu-devel , "Dr. David Alan Gilbert" , Paolo Bonzini , Juan Quintela , Eduardo Habkost To: Radim =?utf-8?B?S3LEjW3DocWZ?= Return-path: Received: from mx1.redhat.com ([209.132.183.28]:48846 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751503AbcKDRMj (ORCPT ); Fri, 4 Nov 2016 13:12:39 -0400 Content-Disposition: inline In-Reply-To: <20161104152522.GC5388@potion> Sender: kvm-owner@vger.kernel.org List-ID: On Fri, Nov 04, 2016 at 04:25:23PM +0100, Radim Krčmář wrote: > > + /* > > + * Transition from VM-running to VM-stopped via migration? > > + * Record when the VM was stopped. > > + */ > > + > > + if (state == RUN_STATE_FINISH_MIGRATE && > > + !migration_in_postcopy(migrate_get_current())) { > > + clock_gettime(CLOCK_MONOTONIC, &s->t_aftervmstop); > > How big (more like small) was the clock delta between here and > kvmclock_pre_save with postcopy? > > Thanks. qemu-system-x86_64: postcopy_ram_supported_by_host: userfaultfd not available: Function not implemented But should be about the same as precopy+this patch (guess as i don't know the postcopy path). From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49915) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c2i2l-0007tT-Gk for qemu-devel@nongnu.org; Fri, 04 Nov 2016 13:12:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c2i2i-0005M5-Cv for qemu-devel@nongnu.org; Fri, 04 Nov 2016 13:12:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43446) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c2i2i-0005Kk-7S for qemu-devel@nongnu.org; Fri, 04 Nov 2016 13:12:40 -0400 Date: Fri, 4 Nov 2016 15:07:52 -0200 From: Marcelo Tosatti Message-ID: <20161104170750.GA4346@amt.cnet> References: <20161104094322.GA16930@amt.cnet> <20161104152522.GC5388@potion> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20161104152522.GC5388@potion> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [QEMU PATCH] kvmclock: advance clock by time window between vm_stop and pre_save List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Radim =?utf-8?B?S3LEjW3DocWZ?= Cc: kvm@vger.kernel.org, qemu-devel , "Dr. David Alan Gilbert" , Paolo Bonzini , Juan Quintela , Eduardo Habkost On Fri, Nov 04, 2016 at 04:25:23PM +0100, Radim Kr=C4=8Dm=C3=A1=C5=99 wro= te: > > + /* > > + * Transition from VM-running to VM-stopped via migration? > > + * Record when the VM was stopped. > > + */ > > + > > + if (state =3D=3D RUN_STATE_FINISH_MIGRATE && > > + !migration_in_postcopy(migrate_get_current())) { > > + clock_gettime(CLOCK_MONOTONIC, &s->t_aftervmstop); >=20 > How big (more like small) was the clock delta between here and > kvmclock_pre_save with postcopy? >=20 > Thanks. qemu-system-x86_64: postcopy_ram_supported_by_host: userfaultfd not available: Function not implemented But should be about the same as precopy+this patch (guess as i don't=20 know the postcopy path).