From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 3/4] drm/i915: Bail if plane/crtc init fails Date: Fri, 4 Nov 2016 23:07:26 +0200 Message-ID: <20161104210726.GU4617@intel.com> References: <1477411083-19255-1-git-send-email-ville.syrjala@linux.intel.com> <1477411083-19255-4-git-send-email-ville.syrjala@linux.intel.com> <20161104204821.GA8566@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 191BA6EAA8 for ; Fri, 4 Nov 2016 21:07:30 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20161104204821.GA8566@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBOb3YgMDQsIDIwMTYgYXQgMDg6NDg6MjFQTSArMDAwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IE9uIFR1ZSwgT2N0IDI1LCAyMDE2IGF0IDA2OjU4OjAyUE0gKzAzMDAsIHZpbGxlLnN5 cmphbGFAbGludXguaW50ZWwuY29tIHdyb3RlOgo+ID4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2 aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiA+IAo+ID4gRHVlIHRvIHRoZSBwbGFuZS0+ aW5kZXggbm90IGdldHRpbmcgcmVhZGp1c3RlZCBpbiBkcm1fcGxhbmVfY2xlYW51cCgpLAo+ID4g d2UgY2FuJ3QgY29udGludWUgaW5pdGlhbGl6YXRpb24gb2Ygc29tZSBwbGFuZS9jcnRjIGluaXQg ZmFpbHMuCj4gPiBXZWxsLCB3ZSBzb3J0IG9mIGNvdWxkIEkgc3VwcG9zZSBpZiB3ZSBsZWZ0IGFs bCBpbml0aWFsaXplZCBwbGFuZXMgb24KPiA+IHRoZSBsaXN0LCBidXQgdGhhdCB3b3VsZCBleHBv c2UgdGhvc2UgcGxhbmVzIHRvIHVzZXJzcGFjZSBhcyB3ZWxsLgo+ID4gCj4gPiBCdXQgZm9yIGNy dGNzIHRoZSBzaXR1YXRpb24gaXMgZXZlbiB3b3JzZSBzaW5jZSB3ZSBhc3N1bWUgdGhhdAo+ID4g cGlwZT09Y3J0YyBpbmRleCBvY2Nhc2lvbmFsbHksIHNvIHdlIGNhbid0IHJlYWxseSBkZWFsIHdp dGggYSBwYXJ0aWFsbHkKPiA+IGluaXRpYWxpemUgc2V0IG9mIGNydGNzLgo+ID4gCj4gPiBTbyBz ZWVtcyBzYWZlc3QgdG8ganVzdCBhYm9ydCB0aGUgZW50aXJlIHRoaW5nIGlmIGFueXRoaW5nIGdv ZXMgd3JvbmcuCj4gPiBBbGwgdGhlIGZhaWx1cmUgcGF0aHMgaGVyZSBhcmUga21hbGxvYygpcyBh bnl3YXksIHNvIGl0IHNlZW1zIHVubGlrZWx5Cj4gPiB3ZSdkIGdldCB2ZXJ5IGZhciBpZiB0aGVz ZSBzdGFydCBmYWlsaW5nLgo+IAo+IHNtYXRjaCBzcG90dGVkIEVSUl9QVFIoMCkKPiAKPiA+IEBA IC0xNTI5NiwyMiArMTUzMDQsMzAgQEAgc3RhdGljIHZvaWQgaW50ZWxfY3J0Y19pbml0KHN0cnVj dCBkcm1fZGV2aWNlICpkZXYsIGludCBwaXBlKQo+ID4gIAl9Cj4gPiAgCj4gPiAgCXByaW1hcnkg PSBpbnRlbF9wcmltYXJ5X3BsYW5lX2NyZWF0ZShkZXYsIHBpcGUpOwo+ID4gLQlpZiAoIXByaW1h cnkpCj4gPiArCWlmIChJU19FUlIocHJpbWFyeSkpIHsKPiA+ICsJCXJldCA9IFBUUl9FUlIocHJp bWFyeSk7Cj4gCj4gSGVyZS4uLgoKVGhpcyBsb29rcyBjb3JyZWN0IHRvIG1lLCBidXQgdGhlIGN1 cnNvciBhbmQgc3ByaXRlIHBhdGhzIGFyZSBjbGVhcmx5CmNyYXAuCgo+IAo+ID4gIAkJZ290byBm YWlsOwo+ID4gKwl9Cj4gPiAgCj4gPiAgCWZvcl9lYWNoX3Nwcml0ZShkZXZfcHJpdiwgcGlwZSwg c3ByaXRlKSB7Cj4gPiAtCQlyZXQgPSBpbnRlbF9wbGFuZV9pbml0KGRldiwgcGlwZSwgc3ByaXRl KTsKPiA+IC0JCWlmIChyZXQpCj4gPiAtCQkJRFJNX0RFQlVHX0tNUygicGlwZSAlYyBzcHJpdGUg JWMgaW5pdCBmYWlsZWQ6ICVkXG4iLAo+ID4gLQkJCQkgICAgICBwaXBlX25hbWUocGlwZSksIHNw cml0ZV9uYW1lKHBpcGUsIHNwcml0ZSksIHJldCk7Cj4gPiArCQlzdHJ1Y3QgaW50ZWxfcGxhbmUg KnBsYW5lOwo+ID4gKwo+ID4gKwkJcGxhbmUgPSBpbnRlbF9zcHJpdGVfcGxhbmVfY3JlYXRlKGRl diwgcGlwZSwgc3ByaXRlKTsKPiA+ICsJCWlmICghcGxhbmUpIHsKPiA+ICsJCQlyZXQgPSBQVFJf RVJSKHBsYW5lKTsKPiAKPiBhbmQgaGVyZS4KPiAKPiAtLSAKPiBDaHJpcyBXaWxzb24sIEludGVs IE9wZW4gU291cmNlIFRlY2hub2xvZ3kgQ2VudHJlCgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVs IE9UQwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRl bC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK