From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Engestrom Subject: Re: [PATCH] drm: move allocation out of drm_get_format_name() Date: Sat, 5 Nov 2016 16:38:44 +0000 Message-ID: <20161105163844.GA29546@engestrom.ch> References: <20161105012344.GA28349@engestrom.ch> <20161105013325.3889-1-eric@engestrom.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Christian =?utf-8?B?S8O2bmln?= Cc: dri-devel@lists.freedesktop.org, Wei Yongjun , Daniel Vetter , Flora Cui , Gustavo Padovan , Tom St Denis , Thomas Hellstrom , Laurent Pinchart , Xinliang Liu , VMware Graphics , Vitaly Prosyak , Alexandre Demers , intel-gfx@lists.freedesktop.org, Emily Deng , Ken Wang , Junwei Zhang , Michel =?utf-8?Q?D=C3=A4nzer?= , linux-kernel@vger.kernel.org, Alex Deucher , Colin Ian King List-Id: dri-devel@lists.freedesktop.org T24gU2F0dXJkYXksIDIwMTYtMTEtMDUgMTM6MTE6MzYgKzAxMDAsIENocmlzdGlhbiBLw7ZuaWcg d3JvdGU6Cj4gQW0gMDUuMTEuMjAxNiB1bSAwMjozMyBzY2hyaWViIEVyaWMgRW5nZXN0cm9tOgo+ ID4gK3R5cGVkZWYgY2hhciBkcm1fZm9ybWF0X25hbWVfYnVmWzMyXTsKPiAKPiBQbGVhc2UgZG9u J3QgdXNlIGEgdHlwZWRlZiBmb3IgdGhpcywganVzdCBkZWZpbmUgdGhlIG1heGltdW0gc2l6ZSBv Zgo+IGNoYXJhY3RlcnMgdGhlIGZ1bmN0aW9uIG1pZ2h0IHdyaXRlIHNvbWV3aGVyZS4KPiAKPiBT ZWUgdGhlIGtlcm5lbCBjb2Rpbmcgc3R5bGUgYXMgd2VsbDoKPiA+IEluIGdlbmVyYWwsIGEgcG9p bnRlciwgb3IgYSBzdHJ1Y3QgdGhhdCBoYXMgZWxlbWVudHMgdGhhdCBjYW4gcmVhc29uYWJseQo+ ID4gYmUgZGlyZWN0bHkgYWNjZXNzZWQgc2hvdWxkICoqbmV2ZXIqKiBiZSBhIHR5cGVkZWYuCj4g CgpJIHdvdWxkIG5vcm1hbGx5IGFncmVlIGFzIEkgdGVuZCB0byBoYXRlIHR5cGVkZWZzICgkREFZ Sk9CIHthYixtaXN9dXNlcwp0aGVtIHdheSB0b28gbXVjaCksIGFuZCB5b3VyIHdheSB3YXMgd2hh dCBJIHdyb3RlIGF0IGZpcnN0LCBidXQgUm9iIENsYXJrJ3MKdHlwZWRlZiBpZGVhIG1ha2VzIGl0 IG11Y2ggaGFyZGVyIGZvciBzb21lb25lIHRvIGFsbG9jYXRlIGEgYnVmZmVyIG9mCnRoZSB3cm9u ZyBzaXplLCB3aGljaCBJTU8gaXMgZ29vZCB0aGluZyBoZXJlLgoKSSBjYW4gcmV3cml0ZSB0aGUg dHlwZWRlZiBvdXQgaWYgeW91IHRoaW5rIGl0J3MgYmV0dGVyLgoKQ2hlZXJzLAogIEVyaWMKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1h aWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756310AbcKEQj4 (ORCPT ); Sat, 5 Nov 2016 12:39:56 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:35062 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752918AbcKEQjz (ORCPT ); Sat, 5 Nov 2016 12:39:55 -0400 Date: Sat, 5 Nov 2016 16:38:44 +0000 From: Eric Engestrom To: Christian =?utf-8?B?S8O2bmln?= Cc: linux-kernel@vger.kernel.org, Ville =?utf-8?B?U3lyasOkbMOk?= , Alex Deucher , David Airlie , Xinliang Liu , Daniel Vetter , Jani Nikula , VMware Graphics , Sinclair Yeh , Thomas Hellstrom , Tom St Denis , Michel =?utf-8?Q?D=C3=A4nzer?= , Gustavo Padovan , Emily Deng , Chunming Zhou , Flora Cui , Vitaly Prosyak , Ken Wang , Colin Ian King , Alexandre Demers , Junwei Zhang , Xinwei Kong , Chris Wilson , Laurent Pinchart , Wei Yongjun , dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm: move allocation out of drm_get_format_name() Message-ID: <20161105163844.GA29546@engestrom.ch> References: <20161105012344.GA28349@engestrom.ch> <20161105013325.3889-1-eric@engestrom.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Saturday, 2016-11-05 13:11:36 +0100, Christian König wrote: > Am 05.11.2016 um 02:33 schrieb Eric Engestrom: > > +typedef char drm_format_name_buf[32]; > > Please don't use a typedef for this, just define the maximum size of > characters the function might write somewhere. > > See the kernel coding style as well: > > In general, a pointer, or a struct that has elements that can reasonably > > be directly accessed should **never** be a typedef. > I would normally agree as I tend to hate typedefs ($DAYJOB {ab,mis}uses them way too much), and your way was what I wrote at first, but Rob Clark's typedef idea makes it much harder for someone to allocate a buffer of the wrong size, which IMO is good thing here. I can rewrite the typedef out if you think it's better. Cheers, Eric