All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] makedevs: resync device creation with upstream busybox
Date: Sat, 5 Nov 2016 23:33:25 +0100	[thread overview]
Message-ID: <20161105233325.5d8c9939@free-electrons.com> (raw)
In-Reply-To: <20161105133812.18485-1-arnout@mind.be>

Hello,

On Sat, 5 Nov 2016 14:38:11 +0100, Arnout Vandecappelle
(Essensium/Mind) wrote:
> In upstream busbyox, the code to create devices has been simplified:
> the code for a single and for multiple devices is no longer duplicated.
> 
> Since we are going to change the device creation code next, it's
> convenient to have only one copy to modify.
> 
> There are two behavioural changes with this, but they were introduced
> silently together with other commits in upstream busybox.
> 
> - When mknod() fails, the chmod was still done. This is pointless so it
>   is no longer done now.
> 
> - There was a check for mode != -1; however, a mode of -1 would not
>   have worked anyway because all bits would be set for mknod(), which
>   would fail. So this check is redundant.
> 
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> ---
>  package/makedevs/makedevs.c | 47 +++++++++++++++------------------------------
>  1 file changed, 15 insertions(+), 32 deletions(-)

Both applied to master, thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      parent reply	other threads:[~2016-11-05 22:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-05 13:38 [Buildroot] [PATCH 1/2] makedevs: resync device creation with upstream busybox Arnout Vandecappelle
2016-11-05 13:38 ` [Buildroot] [PATCH 2/2] makedevs: make device node creation idempotent Arnout Vandecappelle
2016-11-05 15:04   ` Fabio Estevam
2016-11-05 17:20   ` Yann E. MORIN
2016-11-05 15:03 ` [Buildroot] [PATCH 1/2] makedevs: resync device creation with upstream busybox Fabio Estevam
2016-11-05 17:19 ` Yann E. MORIN
2016-11-05 22:33 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161105233325.5d8c9939@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.