From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37381)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1c3HXL-0001QS-M3
	for qemu-devel@nongnu.org; Sun, 06 Nov 2016 02:06:40 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1c3HXG-0002Bn-Nk
	for qemu-devel@nongnu.org; Sun, 06 Nov 2016 02:06:39 -0500
Received: from mx1.redhat.com ([209.132.183.28]:46856)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <mst@redhat.com>) id 1c3HXG-0002Aw-Hv
	for qemu-devel@nongnu.org; Sun, 06 Nov 2016 02:06:34 -0500
Date: Sun, 6 Nov 2016 09:06:31 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20161106090458-mutt-send-email-mst@kernel.org>
References: <1478330391-74060-1-git-send-email-chao.p.peng@linux.intel.com>
	<1478330391-74060-5-git-send-email-chao.p.peng@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1478330391-74060-5-git-send-email-chao.p.peng@linux.intel.com>
Subject: Re: [Qemu-devel] [PATCH 4/4] q35: introduce q35-lite
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Chao Peng <chao.p.peng@linux.intel.com>
Cc: qemu-devel@nongnu.org, Richard Henderson <rth@twiddle.net>, Paolo Bonzini <pbonzini@redhat.com>, Eduardo Habkost <ehabkost@redhat.com>

On Sat, Nov 05, 2016 at 03:19:51AM -0400, Chao Peng wrote:
> This patch introduces a light weight machine type which shares the
> same codebase with existing q35 machine type but with some features
> disabled by default.
> 
> Signed-off-by: Chao Peng <chao.p.peng@linux.intel.com>

I don't find this too useful, but if others do and send acks, I'll merge
it, but only if it also has migration disabled.

> ---
>  hw/i386/pc_q35.c | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
> diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c
> index d042fe0..1c6b476 100644
> --- a/hw/i386/pc_q35.c
> +++ b/hw/i386/pc_q35.c
> @@ -276,6 +276,15 @@ static void pc_q35_init(MachineState *machine)
>      }
>  }
>  
> +static void pc_q35_lite_init(MachineState *machine)
> +{
> +    PCMachineState *pcms = PC_MACHINE(machine);
> +
> +    pcms->smbus = false;
> +    pcms->sata = false;
> +    pcms->pit = false;
> +}
> +
>  #define DEFINE_Q35_MACHINE(suffix, name, compatfn, optionfn) \
>      static void pc_init_##suffix(MachineState *machine) \
>      { \
> @@ -301,6 +310,15 @@ static void pc_q35_machine_options(MachineClass *m)
>      m->max_cpus = 288;
>  }
>  
> +static void pc_q35_lite_machine_options(MachineClass *m)
> +{
> +    pc_q35_machine_options(m);
> +    m->alias = "q35-lite";
> +}
> +
> +DEFINE_Q35_MACHINE(lite, "pc-q35-lite", pc_q35_lite_init,
> +                   pc_q35_lite_machine_options);
> +
>  static void pc_q35_2_8_machine_options(MachineClass *m)
>  {
>      pc_q35_machine_options(m);
> -- 
> 1.8.3.1