All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: linux-mtd@lists.infradead.org, Enrico Jorns <ejo@pengutronix.de>,
	Jingoo Han <jg1.han@samsung.com>,
	Sachin Kamat <sachin.kamat@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Graham Moore <grmoore@opensource.altera.com>,
	Stephen Boyd <stephen.boyd@linaro.org>,
	Dinh Nguyen <dinguyen@altera.com>,
	linux-kernel@vger.kernel.org,
	Brian Norris <computersforpeace@gmail.com>,
	Richard Weinberger <richard@nod.at>,
	David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH] mtd: nand: denali_dt: replace clk_disable() with clk_disable_unprepare()
Date: Sun, 6 Nov 2016 23:55:45 +0100	[thread overview]
Message-ID: <20161106235545.779797fe@bbrezillon> (raw)
In-Reply-To: <1478107264-21139-1-git-send-email-yamada.masahiro@socionext.com>

On Thu,  3 Nov 2016 02:21:04 +0900
Masahiro Yamada <yamada.masahiro@socionext.com> wrote:

> The denali_dt_probe() calls clk_disable_unprepare() in the bailout
> path, whereas denali_dt_remove calls clk_disable(), inconsistently.
> Replace the latter with clk_disable_unprepare() to make sure to
> unprepare the clock.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

Applied.

Thanks,

Boris

> ---
> 
>  drivers/mtd/nand/denali_dt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/denali_dt.c b/drivers/mtd/nand/denali_dt.c
> index 0cb1e8d..f821dc1 100644
> --- a/drivers/mtd/nand/denali_dt.c
> +++ b/drivers/mtd/nand/denali_dt.c
> @@ -110,7 +110,7 @@ static int denali_dt_remove(struct platform_device *ofdev)
>  	struct denali_dt *dt = platform_get_drvdata(ofdev);
>  
>  	denali_remove(&dt->denali);
> -	clk_disable(dt->clk);
> +	clk_disable_unprepare(dt->clk);
>  
>  	return 0;
>  }

      parent reply	other threads:[~2016-11-06 22:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-02 17:21 [PATCH] mtd: nand: denali_dt: replace clk_disable() with clk_disable_unprepare() Masahiro Yamada
2016-11-05  7:26 ` Marek Vasut
2016-11-06 22:55 ` Boris Brezillon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161106235545.779797fe@bbrezillon \
    --to=boris.brezillon@free-electrons.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=computersforpeace@gmail.com \
    --cc=dinguyen@altera.com \
    --cc=dwmw2@infradead.org \
    --cc=ejo@pengutronix.de \
    --cc=grmoore@opensource.altera.com \
    --cc=jg1.han@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=richard@nod.at \
    --cc=sachin.kamat@linaro.org \
    --cc=stephen.boyd@linaro.org \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.