From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gustavo Padovan Date: Mon, 07 Nov 2016 01:19:57 +0000 Subject: Re: [PATCH] drm/sun4i: Propagate error to the caller Message-Id: <20161107011957.GK3327@joana> List-Id: References: <20161104061352.12596-1-christophe.jaillet@wanadoo.fr> In-Reply-To: <20161104061352.12596-1-christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Christophe JAILLET Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, wens@csie.org, maxime.ripard@free-electrons.com, linux-arm-kernel@lists.infradead.org Hi Christophe, 2016-11-04 Christophe JAILLET : > If 'sun4i_layers_init()' returns an error, propagate it instead of > returning -EINVAL unconditionally. > > Signed-off-by: Christophe JAILLET > --- > drivers/gpu/drm/sun4i/sun4i_drv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Gustavo Padovan Gustavo From mboxrd@z Thu Jan 1 00:00:00 1970 From: gustavo@padovan.org (Gustavo Padovan) Date: Mon, 7 Nov 2016 10:19:57 +0900 Subject: [PATCH] drm/sun4i: Propagate error to the caller In-Reply-To: <20161104061352.12596-1-christophe.jaillet@wanadoo.fr> References: <20161104061352.12596-1-christophe.jaillet@wanadoo.fr> Message-ID: <20161107011957.GK3327@joana> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Christophe, 2016-11-04 Christophe JAILLET : > If 'sun4i_layers_init()' returns an error, propagate it instead of > returning -EINVAL unconditionally. > > Signed-off-by: Christophe JAILLET > --- > drivers/gpu/drm/sun4i/sun4i_drv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Gustavo Padovan Gustavo From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gustavo Padovan Subject: Re: [PATCH] drm/sun4i: Propagate error to the caller Date: Mon, 7 Nov 2016 10:19:57 +0900 Message-ID: <20161107011957.GK3327@joana> References: <20161104061352.12596-1-christophe.jaillet@wanadoo.fr> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-pf0-f195.google.com (mail-pf0-f195.google.com [209.85.192.195]) by gabe.freedesktop.org (Postfix) with ESMTPS id 01D7E6E259 for ; Mon, 7 Nov 2016 01:20:06 +0000 (UTC) Received: by mail-pf0-f195.google.com with SMTP id i88so14560305pfk.2 for ; Sun, 06 Nov 2016 17:20:05 -0800 (PST) Content-Disposition: inline In-Reply-To: <20161104061352.12596-1-christophe.jaillet@wanadoo.fr> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Christophe JAILLET Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, wens@csie.org, maxime.ripard@free-electrons.com, linux-arm-kernel@lists.infradead.org List-Id: dri-devel@lists.freedesktop.org SGkgQ2hyaXN0b3BoZSwKCjIwMTYtMTEtMDQgQ2hyaXN0b3BoZSBKQUlMTEVUIDxjaHJpc3RvcGhl LmphaWxsZXRAd2FuYWRvby5mcj46Cgo+IElmICdzdW40aV9sYXllcnNfaW5pdCgpJyByZXR1cm5z IGFuIGVycm9yLCBwcm9wYWdhdGUgaXQgaW5zdGVhZCBvZgo+IHJldHVybmluZyAtRUlOVkFMIHVu Y29uZGl0aW9uYWxseS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBDaHJpc3RvcGhlIEpBSUxMRVQgPGNo cmlzdG9waGUuamFpbGxldEB3YW5hZG9vLmZyPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vc3Vu NGkvc3VuNGlfZHJ2LmMgfCAyICstCj4gIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwg MSBkZWxldGlvbigtKQoKUmV2aWV3ZWQtYnk6IEd1c3Rhdm8gUGFkb3ZhbiA8Z3VzdGF2by5wYWRv dmFuQGNvbGxhYm9yYS5jby51az4KCkd1c3Rhdm8KX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751712AbcKGBUR (ORCPT ); Sun, 6 Nov 2016 20:20:17 -0500 Received: from mail-pf0-f195.google.com ([209.85.192.195]:33308 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751175AbcKGBUM (ORCPT ); Sun, 6 Nov 2016 20:20:12 -0500 Date: Mon, 7 Nov 2016 10:19:57 +0900 From: Gustavo Padovan To: Christophe JAILLET Cc: maxime.ripard@free-electrons.com, wens@csie.org, airlied@linux.ie, kernel-janitors@vger.kernel.org, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/sun4i: Propagate error to the caller Message-ID: <20161107011957.GK3327@joana> Mail-Followup-To: Gustavo Padovan , Christophe JAILLET , maxime.ripard@free-electrons.com, wens@csie.org, airlied@linux.ie, kernel-janitors@vger.kernel.org, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20161104061352.12596-1-christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161104061352.12596-1-christophe.jaillet@wanadoo.fr> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Christophe, 2016-11-04 Christophe JAILLET : > If 'sun4i_layers_init()' returns an error, propagate it instead of > returning -EINVAL unconditionally. > > Signed-off-by: Christophe JAILLET > --- > drivers/gpu/drm/sun4i/sun4i_drv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Gustavo Padovan Gustavo