From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59663)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <olaf@aepfle.de>) id 1c3fGu-0007jF-4T
	for qemu-devel@nongnu.org; Mon, 07 Nov 2016 03:27:16 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <olaf@aepfle.de>) id 1c3fGt-0000hB-4h
	for qemu-devel@nongnu.org; Mon, 07 Nov 2016 03:27:16 -0500
Date: Mon, 7 Nov 2016 09:26:55 +0100
From: Olaf Hering <olaf@aepfle.de>
Message-ID: <20161107082655.GA8821@aepfle.de>
References: <1475479496-16158-1-git-send-email-clg@kaod.org>
	<1475479496-16158-7-git-send-email-clg@kaod.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="+QahgC5+KEYLbs62"
Content-Disposition: inline
In-Reply-To: <1475479496-16158-7-git-send-email-clg@kaod.org>
Subject: Re: [Qemu-devel] [PATCH v4 06/20] ppc/pnv: add XSCOM infrastructure
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?utf-8?Q?C=C3=A9dric?= Le Goater <clg@kaod.org>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, David Gibson <david@gibson.dropbear.id.au>


--+QahgC5+KEYLbs62
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Oct 03, C=C3=A9dric Le Goater wrote:

> +++ b/include/hw/ppc/pnv_xscom.h

> +typedef struct PnvChip PnvChip;

This causes a compile error with gcc 4.5.1:

=2E..
[  552s] In file included from /usr/src/packages/BUILD/qemu-20161104T092624=
=2E9226682/hw/ppc/pnv.c:29:0:
[  552s] /usr/src/packages/BUILD/qemu-20161104T092624.9226682/include/hw/pp=
c/pnv.h:60:3: error: redefinition of typedef 'PnvChip'
[  552s] /usr/src/packages/BUILD/qemu-20161104T092624.9226682/include/hw/pp=
c/pnv_xscom.h:24:24: note: previous declaration of 'PnvChip' was here
[  552s] make[1]: *** [hw/ppc/pnv.o] Error 1
[  552s] make[1]: Leaving directory `/usr/src/packages/BUILD/qemu-20161104T=
092624.9226682/ppc64-softmmu'
[  552s] make: *** [subdir-ppc64-softmmu] Error 2
=2E..

Olaf

--+QahgC5+KEYLbs62
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iEYEARECAAYFAlggOswACgkQXUKg+qaYNn41ugCfZ5VPHHdE4SJqKdoEej7N3Rfh
IGkAn0DHat8w5R3sDn6yh52I+pWp6u0n
=zsi1
-----END PGP SIGNATURE-----

--+QahgC5+KEYLbs62--