From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Date: Mon, 7 Nov 2016 09:39:30 +0100 Subject: [U-Boot] [PATCH 2/4] mmc: sunxi: Enable 8bits bus width for sun8i In-Reply-To: References: <05bcf982c223a160cb5a95607c034000d2e5e62b.1478272627.git-series.maxime.ripard@free-electrons.com> <20161106171535.5jk7bqcfv3mad7b3@lukather> Message-ID: <20161107083930.ynpvdioskrs33wdk@lukather> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de 1;4600;0c On Mon, Nov 07, 2016 at 09:53:00AM +0800, Chen-Yu Tsai wrote: > On Mon, Nov 7, 2016 at 1:15 AM, Maxime Ripard > wrote: > > On Sat, Nov 05, 2016 at 09:34:25AM +0800, Chen-Yu Tsai wrote: > >> On Fri, Nov 4, 2016 at 11:18 PM, Maxime Ripard > >> wrote: > >> > The sun8i SoCs also have a 8 bits capable MMC2 controller. Enable the > >> > support for those too. > >> > > >> > Signed-off-by: Maxime Ripard > >> > --- > >> > drivers/mmc/sunxi_mmc.c | 2 +- > >> > 1 file changed, 1 insertion(+), 1 deletion(-) > >> > > >> > diff --git a/drivers/mmc/sunxi_mmc.c b/drivers/mmc/sunxi_mmc.c > >> > index 6953accce123..b8716c93cb06 100644 > >> > --- a/drivers/mmc/sunxi_mmc.c > >> > +++ b/drivers/mmc/sunxi_mmc.c > >> > @@ -463,7 +463,7 @@ struct mmc *sunxi_mmc_init(int sdc_no) > >> > > >> > cfg->voltages = MMC_VDD_32_33 | MMC_VDD_33_34; > >> > cfg->host_caps = MMC_MODE_4BIT; > >> > -#ifdef CONFIG_MACH_SUN50I > >> > +#if defined(CONFIG_MACH_SUN50I) || defined(CONFIG_MACH_SUN8I) > >> > >> 8 come before 50. :) > > > > But 5 comes before 8, and 0 before i :) > > Indeed, though 8 and 50 are akin to a generation number, so > it makes sense to sort them in natural order. :) I know, but it was one of the comments I had in Linux, and we used that ordering there. And we probably want to be consistent, but I don't really care. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 801 bytes Desc: not available URL: