Re: [PATCH 1/2] mfd: syscon: Support native-endian regmaps

[Lee Jones <lee.jones@linaro.org>]

On Sat, 05 Nov 2016, Guenter Roeck wrote:

> On 10/14/2016 02:17 AM, Paul Burton wrote:
> > The regmap devicetree binding documentation states that a native-endian
> > property should be supported as well as big-endian & little-endian,
> > however syscon in its duplication of the parsing of these properties
> > omits support for native-endian. Fix this by setting
> > REGMAP_ENDIAN_NATIVE when a native-endian property is found.
> > 
> 
> Any chance to get this patch applied to mainline ? It is in -next, but
> big endian mips malta images still fail to reboot in mainline.

Applied to -fixes.

> > Signed-off-by: Paul Burton <paul.burton@imgtec.com>
> > Cc: Lee Jones <lee.jones@linaro.org>
> > Cc: Arnd Bergmann <arnd@arndb.de>
> > Cc: Guenter Roeck <linux@roeck-us.net>
> > Cc: Ralf Baechle <ralf@linux-mips.org>
> > Cc: linux-mips@linux-mips.org
> > ---
> >  drivers/mfd/syscon.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/mfd/syscon.c b/drivers/mfd/syscon.c
> > index 2f2225e..b93fe4c 100644
> > --- a/drivers/mfd/syscon.c
> > +++ b/drivers/mfd/syscon.c
> > @@ -73,8 +73,10 @@ static struct syscon *of_syscon_register(struct device_node *np)
> >  	/* Parse the device's DT node for an endianness specification */
> >  	if (of_property_read_bool(np, "big-endian"))
> >  		syscon_config.val_format_endian = REGMAP_ENDIAN_BIG;
> > -	 else if (of_property_read_bool(np, "little-endian"))
> > +	else if (of_property_read_bool(np, "little-endian"))
> >  		syscon_config.val_format_endian = REGMAP_ENDIAN_LITTLE;
> > +	else if (of_property_read_bool(np, "native-endian"))
> > +		syscon_config.val_format_endian = REGMAP_ENDIAN_NATIVE;
> > 
> >  	/*
> >  	 * search for reg-io-width property in DT. If it is not provided,
> > 
> 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog