From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54837) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c3mfv-0005AE-Ut for qemu-devel@nongnu.org; Mon, 07 Nov 2016 11:21:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c3mfr-000450-0U for qemu-devel@nongnu.org; Mon, 07 Nov 2016 11:21:35 -0500 Received: from mx1.redhat.com ([209.132.183.28]:55112) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c3mfq-00044o-R9 for qemu-devel@nongnu.org; Mon, 07 Nov 2016 11:21:30 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2265C69185 for ; Mon, 7 Nov 2016 16:21:30 +0000 (UTC) Date: Tue, 8 Nov 2016 00:21:28 +0800 From: Peter Xu Message-ID: <20161107162128.GC3719@pxdev.xzpeter.org> References: <1475580151-3856-1-git-send-email-maxime.coquelin@redhat.com> <2f10cdd9-0424-d61e-a36b-5c4895ecffbb@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <2f10cdd9-0424-d61e-a36b-5c4895ecffbb@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2] scripts: qmp: Introduce vcpu pinning helper script List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Maxime Coquelin Cc: armbru@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com On Thu, Nov 03, 2016 at 04:01:08PM +0100, Maxime Coquelin wrote: > Hi Peter, > > On 10/04/2016 01:22 PM, Maxime Coquelin wrote: > >This python script calls 'query-cpus' QMP command to retrieve > >vCPUs thread IDs. > >Thread IDs are then used by taskset to pin vCPUs to physical > >CPUs passed in command line. > > > >In case more vCPUs are present than the number of CPUs assigned > >in command line, multiple vCPUs get pinned to physical CPUs. > > > >If multiple vCPUs share a same thread ID (e.g. with TCG), the > >thread ID is pinned a single time. > > > >Signed-off-by: Maxime Coquelin > >--- > >Changes since RFC: > >================== > > - If vCPUs share a same TID, don't pin them multiple times (peterx) > > > > scripts/qmp/qmp-vcpu-pin | 45 +++++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 45 insertions(+) > > create mode 100755 scripts/qmp/qmp-vcpu-pin > > I added your proposed change not to pin same TID multiple time, > does it look good to you? Though I am still not familiar with the python and QMP stuffs, but yes this looks good to me, so: Reviewed-by: Peter Xu Sorry for the late response. -- peterx