From: Florian Westphal <fw@strlen.de>
To: Florian Westphal <fw@strlen.de>
Cc: David Buchmann <david@jazznetworks.com>, netfilter-devel@vger.kernel.org
Subject: Re: nfqueue: Get pid of socket owner
Date: Mon, 7 Nov 2016 18:09:33 +0100 [thread overview]
Message-ID: <20161107170933.GC24908@breakpoint.cc> (raw)
In-Reply-To: <20161107163832.GB24908@breakpoint.cc>
Florian Westphal <fw@strlen.de> wrote:
> David Buchmann <david@jazznetworks.com> wrote:
> > I've started work to add support in the nfnetlink_queue kernel module for
> > sending the pid of the process owning the socket triggering nfqueue, and I
> > want to add the userspace support in libnetfilter_queue, but before I get
> > too invested in that work I just want to check whether there are any
> > objections to such a feature in either the kernel or in the
> > libnetfilter_queue library?
> >
> > https://github.com/wuurrd/linux/commit/79d12e93ca2a28c0939937a5a690943311e4bf6c
>
> I think this should just be added to nfqnl_put_sk_uidgid(), and just use
> the new sk->sk_uid that got added to net-next recently:
Grrr, too late, sorry :/
I think you should add this to nfqnl_put_sk_uidgid though, no need to
grab the locks twice.
We'd also have to add appropriate warnings that this pid isn't reliable.
next prev parent reply other threads:[~2016-11-07 17:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-07 14:21 nfqueue: Get pid of socket owner David Buchmann
2016-11-07 16:38 ` Florian Westphal
2016-11-07 17:09 ` Florian Westphal [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-11-08 11:32 David Buchmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161107170933.GC24908@breakpoint.cc \
--to=fw@strlen.de \
--cc=david@jazznetworks.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.