From: Gautham R Shenoy <ego@linux.vnet.ibm.com>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: Denis Kirjanov <kda@linux-powerpc.org>,
linuxppc-dev@lists.ozlabs.org, ego@linux.vnet.ibm.com,
Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com>,
Akshay Adiga <akshay.adiga@linux.vnet.ibm.com>
Subject: Re: [PATCH v2] ppc: cpufreq: disable preemption while checking CPU throttling state
Date: Tue, 8 Nov 2016 08:47:20 +0530 [thread overview]
Message-ID: <20161108031720.GB24936@in.ibm.com> (raw)
In-Reply-To: <87k2celt30.fsf@concordia.ellerman.id.au>
Hi Michael,
On Tue, Nov 08, 2016 at 11:21:23AM +1100, Michael Ellerman wrote:
> Denis Kirjanov <kda@linux-powerpc.org> writes:
> > On 11/7/16, Michael Ellerman <mpe@ellerman.id.au> wrote:
> >> Denis Kirjanov <kda@linux-powerpc.org> writes:
> >>> [ 67.700897] BUG: using smp_processor_id() in preemptible [00000000] code: cat/7343
> >>> [ 67.700988] caller is .powernv_cpufreq_throttle_check+0x2c/0x710
> >>
> >> When did this break?
> >
> > I think that problem exists since commit
> > 09a972d1620934142d30cfda455ffe429af751c4 ("cpufreq: powernv: Report
> > cpu frequency throttling") but I can be wrong
>
> Yep that looks right to me, thanks.
>
> Gautham, how bad is the bug here, do we want to send this to stable?
Not so bad that it needs to be sent to stable immediately.
On CONFIG_PREEMPT enabled systems, if task executing
powernv_cpufreq_throttle_check can be switched to a CPU on a different
chip, then we will end up incorrectly attributing the throttle
statistics of the new chip to the chip where it previously ran. These
throttle statistics aren't used inside the kernel for any computation,
but are reported to the user via /sysfs for them to account for any
variance during a benchmark run.
It would be good to include this in the 4.9 fixes though.
>
> cheers
>
next prev parent reply other threads:[~2016-11-08 3:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-04 11:08 [PATCH v2] ppc: cpufreq: disable preemption while checking CPU throttling state Denis Kirjanov
2016-11-07 2:31 ` Gautham R Shenoy
2016-11-07 5:15 ` Denis Kirjanov
2016-11-07 7:36 ` Michael Ellerman
2016-11-07 8:02 ` Denis Kirjanov
2016-11-08 0:21 ` Michael Ellerman
2016-11-08 3:17 ` Gautham R Shenoy [this message]
2016-11-08 8:27 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161108031720.GB24936@in.ibm.com \
--to=ego@linux.vnet.ibm.com \
--cc=akshay.adiga@linux.vnet.ibm.com \
--cc=kda@linux-powerpc.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=shilpa.bhat@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.