Re: [Qemu-devel] [PATCH 3/3] Split ISA and sysbus versions of m48t59 device

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1276 bytes --]

On Fri, Nov 04, 2016 at 08:28:25AM -0500, Eric Blake wrote:
> On 11/04/2016 05:22 AM, Markus Armbruster wrote:
> > Needs a rebase.  First error:
> > 
> >   CC      hw/timer/m48t59.o
> > In file included from /work/armbru/qemu/include/exec/cpu-common.h:7:0,
> >                  from /work/armbru/qemu/include/exec/memory.h:24,
> >                  from /work/armbru/qemu/include/hw/isa/isa.h:6,
> >                  from /work/armbru/qemu/hw/timer/m48t59-isa.c:25:
> > /work/armbru/qemu/include/exec/hwaddr.h:11:9: error: unknown type name ‘uint64_t’
> >  typedef uint64_t hwaddr;
> >          ^
> > 
> 
> >> index 0000000..3a521dc
> >> --- /dev/null
> >> +++ b/hw/timer/m48t59-isa.c
> 
> >> + * THE SOFTWARE.
> >> + */
> >> +#include "hw/isa/isa.h"
> 
> Probably because you forgot osdep.h as the first include.

That, plus I stupidly re-used the same double-include prevention
symbol from an existing header file.  I've fixed that up in my branch
now.

Of course, I still have no idea who I really need to convince to
actually get this merged.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]