From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Eugene Korenevsky <ekorenevsky@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
Luiz Capitulino <lcapitulino@redhat.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Chase Metzger <chasemetzger15@gmail.com>,
Alan Stern <stern@rowland.harvard.edu>,
Mathias Nyman <mathias.nyman@linux.intel.com>,
Lu Baolu <baolu.lu@linux.intel.com>,
Oliver Neukum <oneukum@suse.com>, Hans Yang <hansy@nvidia.com>
Subject: Re: [PATCH v3 1/2] USB hub_probe: rework ugly goto-into-compound-statement
Date: Tue, 8 Nov 2016 07:50:58 +0100 [thread overview]
Message-ID: <20161108065058.GC13024@kroah.com> (raw)
In-Reply-To: <20161107185350.GA18986@vnote>
On Mon, Nov 07, 2016 at 09:53:50PM +0300, Eugene Korenevsky wrote:
> Rework smelling code (goto inside compound statement). Perhaps this is
> legacy. Anyway such code is not appropriate for Linux kernel.
>
> Signed-off-by: Eugene Korenevsky <ekorenevsky@gmail.com>
> ---
> drivers/usb/core/hub.c | 33 ++++++++++++++++-----------------
> 1 file changed, 16 insertions(+), 17 deletions(-)
You forgot to list what changed from v2 here :(
next prev parent reply other threads:[~2016-11-08 6:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-07 18:53 [PATCH v3 1/2] USB hub_probe: rework ugly goto-into-compound-statement Eugene Korenevsky
2016-11-08 6:50 ` Greg Kroah-Hartman [this message]
2016-11-08 6:51 ` Greg Kroah-Hartman
2016-11-09 2:36 ` [USB hub_probe] 384bb29a55: kmsg.hub#-#:#:bad_descriptor, ignoring_hub kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161108065058.GC13024@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=baolu.lu@linux.intel.com \
--cc=chasemetzger15@gmail.com \
--cc=ekorenevsky@gmail.com \
--cc=hansy@nvidia.com \
--cc=lcapitulino@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
--cc=oneukum@suse.com \
--cc=stern@rowland.harvard.edu \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.