From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: Re: [PATCH] Revert "console: don't prefer first registered if DT specifies stdout-path" Date: Tue, 8 Nov 2016 08:00:32 +0100 Message-ID: <20161108070032.GB13866@kroah.com> References: <20161104121135.4780-1-hdegoede@redhat.com> <20161104121135.4780-2-hdegoede@redhat.com> <87h97ilrx0.fsf@concordia.ellerman.id.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <87h97ilrx0.fsf-W0DJWXSxmBNbyGPkN3NxC2scP1bn1w/D@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Michael Ellerman Cc: Linus Torvalds , Hans de Goede , Andrew Morton , Paul Burton , Rob Herring , Frank Rowand , Thorsten Leemhuis , Tejun Heo , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On Tue, Nov 08, 2016 at 11:46:35AM +1100, Michael Ellerman wrote: > Hans de Goede writes: > > > This reverts commit 05fd007e4629 ("console: don't prefer first registered > > if DT specifies stdout-path"). > > > > The reverted commit changes existing behavior on which many ARM boards > > rely. Many ARM small-board-computers, like e.g. the Raspberry Pi have > > both a video output and a serial console. Depending on whether the user > > is using the device as a more regular computer; or as a headless device > > we need to have the console on either one or the other. > > > > Many users rely on the kernel behavior of the console being present on > > both outputs, before the reverted commit the console setup with no > > console= kernel arguments on an ARM board which sets stdout-path in dt > > would look like this: > > > > [root@localhost ~]# cat /proc/consoles > > ttyS0 -W- (EC p a) 4:64 > > tty0 -WU (E p ) 4:1 > > > > Where as after the reverted commit, it looks like this: > > > > [root@localhost ~]# cat /proc/consoles > > ttyS0 -W- (EC p a) 4:64 > > > > This commit reverts commit 05fd007e4629 ("console: don't prefer first > > registered if DT specifies stdout-path") restoring the original behavior. > > > > Signed-off-by: Hans de Goede > > This is also breaking various powerpc systems. > > Linus can you please merge this revert for 4.9 ? I'll queue it up with other tty changes for 4.9-final. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751725AbcKHHA0 (ORCPT ); Tue, 8 Nov 2016 02:00:26 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:40278 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751277AbcKHHAY (ORCPT ); Tue, 8 Nov 2016 02:00:24 -0500 Date: Tue, 8 Nov 2016 08:00:32 +0100 From: Greg Kroah-Hartman To: Michael Ellerman Cc: Linus Torvalds , Hans de Goede , Andrew Morton , Paul Burton , Rob Herring , Frank Rowand , Thorsten Leemhuis , Tejun Heo , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Revert "console: don't prefer first registered if DT specifies stdout-path" Message-ID: <20161108070032.GB13866@kroah.com> References: <20161104121135.4780-1-hdegoede@redhat.com> <20161104121135.4780-2-hdegoede@redhat.com> <87h97ilrx0.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87h97ilrx0.fsf@concordia.ellerman.id.au> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 08, 2016 at 11:46:35AM +1100, Michael Ellerman wrote: > Hans de Goede writes: > > > This reverts commit 05fd007e4629 ("console: don't prefer first registered > > if DT specifies stdout-path"). > > > > The reverted commit changes existing behavior on which many ARM boards > > rely. Many ARM small-board-computers, like e.g. the Raspberry Pi have > > both a video output and a serial console. Depending on whether the user > > is using the device as a more regular computer; or as a headless device > > we need to have the console on either one or the other. > > > > Many users rely on the kernel behavior of the console being present on > > both outputs, before the reverted commit the console setup with no > > console= kernel arguments on an ARM board which sets stdout-path in dt > > would look like this: > > > > [root@localhost ~]# cat /proc/consoles > > ttyS0 -W- (EC p a) 4:64 > > tty0 -WU (E p ) 4:1 > > > > Where as after the reverted commit, it looks like this: > > > > [root@localhost ~]# cat /proc/consoles > > ttyS0 -W- (EC p a) 4:64 > > > > This commit reverts commit 05fd007e4629 ("console: don't prefer first > > registered if DT specifies stdout-path") restoring the original behavior. > > > > Signed-off-by: Hans de Goede > > This is also breaking various powerpc systems. > > Linus can you please merge this revert for 4.9 ? I'll queue it up with other tty changes for 4.9-final. thanks, greg k-h