From: Wei Liu <wei.liu2@citrix.com>
To: Juergen Gross <jgross@suse.com>
Cc: samuel.thibault@ens-lyon.org, wei.liu2@citrix.com,
xen-devel@lists.xen.org
Subject: Re: [PATCH] stubdom: remove EXTRA_CFLAGS meant for building tools
Date: Tue, 8 Nov 2016 10:47:18 +0000 [thread overview]
Message-ID: <20161108104718.GC31926@citrix.com> (raw)
In-Reply-To: <1478596181-25250-1-git-send-email-jgross@suse.com>
On Tue, Nov 08, 2016 at 10:09:41AM +0100, Juergen Gross wrote:
> When building stubdoms EXTRA_CFLAGS_XEN_TOOLS and
> EXTRA_CFLAGS_QEMU_TRADITIONAL should be cleared as they might contain
> flags not suitable for all stubdom builds (e.g. "-m64" often to be
> found in $RPM_OPT_FLAGS will break building 32 bit stubdoms).
>
> Signed-off-by: Juergen Gross <jgross@suse.com>
> ---
> stubdom/Makefile | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/stubdom/Makefile b/stubdom/Makefile
> index 2921f30..c89e353 100644
> --- a/stubdom/Makefile
> +++ b/stubdom/Makefile
> @@ -4,6 +4,10 @@ MINI_OS = $(XEN_ROOT)/extras/mini-os
> export XEN_ROOT
> export XEN_OS=MiniOS
>
> +# Remove flags which are meant for tools, e.g. "-m64"
> +export EXTRA_CFLAGS_XEN_TOOLS=
> +export EXTRA_CFLAGS_QEMU_TRADITIONAL=
> +
I can't think of a better way to deal with this. This is in line with
how it is done in firmware build, so
Acked-by: Wei Liu <wei.liu2@citrix.com>
> export stubdom=y
> export debug=y
> # Moved from config/StdGNU.mk
> --
> 2.6.6
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-11-08 10:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-08 9:09 [PATCH] stubdom: remove EXTRA_CFLAGS meant for building tools Juergen Gross
2016-11-08 10:47 ` Wei Liu [this message]
2016-11-08 19:41 ` Samuel Thibault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161108104718.GC31926@citrix.com \
--to=wei.liu2@citrix.com \
--cc=jgross@suse.com \
--cc=samuel.thibault@ens-lyon.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.