From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: Lyude <lyude@redhat.com>
Cc: ibm-acpi-devel@lists.sourceforge.net,
Daniel Martin <consume.noise@gmail.com>,
Darren Hart <dvhart@infradead.org>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/3] thinkpad_acpi: Move tablet detection into separate function
Date: Tue, 8 Nov 2016 08:50:05 -0200 [thread overview]
Message-ID: <20161108105004.GA8609@khazad-dum.debian.net> (raw)
In-Reply-To: <1478538633-11450-1-git-send-email-lyude@redhat.com>
On Mon, 07 Nov 2016, Lyude wrote:
> @@ -3117,6 +3120,34 @@ static const struct tpacpi_quirk tpacpi_hotkey_qtable[] __initconst = {
> typedef u16 tpacpi_keymap_entry_t;
> typedef tpacpi_keymap_entry_t tpacpi_keymap_t[TPACPI_HOTKEY_MAP_LEN];
>
> +static int
> +hotkey_init_tablet_mode(void)
> +{
Function definiton all in one line, please.
Provided that you fix that minor nit,
Acked-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
--
Henrique Holschuh
next prev parent reply other threads:[~2016-11-08 10:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-07 17:10 [PATCH v3 1/3] thinkpad_acpi: Move tablet detection into separate function Lyude
2016-11-07 17:10 ` Lyude
2016-11-08 10:50 ` Henrique de Moraes Holschuh [this message]
[not found] ` <1478538633-11450-1-git-send-email-lyude-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-11-07 17:10 ` [PATCH 2/3] thinkpad_acpi: Don't repeat ourselves in hotkey_init_tablet_mode() Lyude
2016-11-07 17:10 ` Lyude
[not found] ` <1478538633-11450-2-git-send-email-lyude-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-11-08 11:08 ` Henrique de Moraes Holschuh
2016-11-08 11:08 ` Henrique de Moraes Holschuh
2016-11-07 17:10 ` [PATCH v4 3/3] thinkpad_acpi: Add support for X1 Yoga (2016) Tablet Mode Lyude
2016-11-07 17:10 ` Lyude
2016-11-08 11:01 ` Henrique de Moraes Holschuh
2016-11-09 11:10 ` [PATCH v3 1/3] thinkpad_acpi: Move tablet detection into separate function Daniel Martin
2016-11-09 11:10 ` Daniel Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161108105004.GA8609@khazad-dum.debian.net \
--to=hmh@hmh.eng.br \
--cc=consume.noise@gmail.com \
--cc=dvhart@infradead.org \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.