From mboxrd@z Thu Jan 1 00:00:00 1970 From: Henrique de Moraes Holschuh Subject: Re: [PATCH 2/3] thinkpad_acpi: Don't repeat ourselves in hotkey_init_tablet_mode() Date: Tue, 8 Nov 2016 09:08:47 -0200 Message-ID: <20161108110847.GC8609@khazad-dum.debian.net> References: <1478538633-11450-1-git-send-email-lyude@redhat.com> <1478538633-11450-2-git-send-email-lyude@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1478538633-11450-2-git-send-email-lyude-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ibm-acpi-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Lyude Cc: ibm-acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Daniel Martin , platform-driver-x86-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Darren Hart List-Id: platform-driver-x86.vger.kernel.org On Mon, 07 Nov 2016, Lyude wrote: > There's no need to have multiple copies of the logic we use for checking > whether or not we're in tablet mode, so just use > hotkey_get_tablet_mode() when checking the initial state in > hotkey_init_tablet_mode(). ... > @@ -3130,13 +3130,16 @@ hotkey_init_tablet_mode(void) > /* For X41t, X60t, X61t Tablets... */ > if (acpi_evalf(hkey_handle, &res, "MHKG", "qd")) { > tp_features.hotkey_tablet = TP_HOTKEY_TABLET_USES_MHKG; > - in_tablet_mode = !!(res & TP_HOTKEY_TABLET_MASK); > type = "MHKG"; > } > > if (!tp_features.hotkey_tablet) > return 0; > > + res = hotkey_get_tablet_mode(&in_tablet_mode); > + if (res) > + return res; > + Won't this way of doing things cause the ACPI methods to be called twice in a row? The hotkey_init_tablet_mode() code does mode detection, and thus hotkey_get_tablet_mode() must be kept in sync with it *anyway* (and not the opposite), so it doesn't look like a very relevant maintenance burden... -- Henrique Holschuh ------------------------------------------------------------------------------ Developer Access Program for Intel Xeon Phi Processors Access to Intel Xeon Phi processor-based developer platforms. With one year of Intel Parallel Studio XE. Training and support from Colfax. Order your platform today. http://sdm.link/xeonphi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753346AbcKHLKG (ORCPT ); Tue, 8 Nov 2016 06:10:06 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:44618 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753205AbcKHLKD (ORCPT ); Tue, 8 Nov 2016 06:10:03 -0500 X-ME-Sender: X-Sasl-enc: NhrQIwK3xJ3H1EnXWZkrVKg3VkBEFYaO8ybZ4TrnsJi6 1478603329 Date: Tue, 8 Nov 2016 09:08:47 -0200 From: Henrique de Moraes Holschuh To: Lyude Cc: ibm-acpi-devel@lists.sourceforge.net, Daniel Martin , Darren Hart , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] thinkpad_acpi: Don't repeat ourselves in hotkey_init_tablet_mode() Message-ID: <20161108110847.GC8609@khazad-dum.debian.net> References: <1478538633-11450-1-git-send-email-lyude@redhat.com> <1478538633-11450-2-git-send-email-lyude@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1478538633-11450-2-git-send-email-lyude@redhat.com> X-GPG-Fingerprint1: 4096R/0x0BD9E81139CB4807: C467 A717 507B BAFE D3C1 6092 0BD9 E811 39CB 4807 User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 07 Nov 2016, Lyude wrote: > There's no need to have multiple copies of the logic we use for checking > whether or not we're in tablet mode, so just use > hotkey_get_tablet_mode() when checking the initial state in > hotkey_init_tablet_mode(). ... > @@ -3130,13 +3130,16 @@ hotkey_init_tablet_mode(void) > /* For X41t, X60t, X61t Tablets... */ > if (acpi_evalf(hkey_handle, &res, "MHKG", "qd")) { > tp_features.hotkey_tablet = TP_HOTKEY_TABLET_USES_MHKG; > - in_tablet_mode = !!(res & TP_HOTKEY_TABLET_MASK); > type = "MHKG"; > } > > if (!tp_features.hotkey_tablet) > return 0; > > + res = hotkey_get_tablet_mode(&in_tablet_mode); > + if (res) > + return res; > + Won't this way of doing things cause the ACPI methods to be called twice in a row? The hotkey_init_tablet_mode() code does mode detection, and thus hotkey_get_tablet_mode() must be kept in sync with it *anyway* (and not the opposite), so it doesn't look like a very relevant maintenance burden... -- Henrique Holschuh