From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chen Yu Subject: Re: [PATCH 1/2][RFC v6] timekeeping: Ignore the bogus sleep time if pm_trace is enabled Date: Tue, 8 Nov 2016 20:50:06 +0800 Message-ID: <20161108125006.GD7191@yu-desktop-1.sh.intel.com> References: Reply-To: rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Sender: rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org Cc: Pavel Machek , Ingo Molnar , "H. Peter Anvin" , linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Thomas Gleixner , "Rafael J. Wysocki" , Len Brown , John Stultz , Xunlei Pang List-Id: linux-pm@vger.kernel.org On Tue, Nov 08, 2016 at 05:01:35PM +0800, Chen Yu wrote: > From: Thomas Gleixner > > Previously we encountered some memory overflow issues due to > the bogus sleep time brought by inconsistent rtc, which is > triggered when pm_trace is enabled, and we have fixed it > in recent kernel. However it's improper in the first place > to call __timekeeping_inject_sleeptime() in case that pm_trace > is enabled simply because that "hash" time value will wreckage > the timekeeping subsystem. > > This patch is to bypass the bogus rtc interval when pm_trace is enabled. > > Cc: Thomas Gleixner > Cc: "Rafael J. Wysocki" > Cc: Len Brown > Cc: John Stultz > Cc: Xunlei Pang > Signed-off-by: Chen Yu > --- > [cut] Will resend another version. Thanks. -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Sender: rtc-linux@googlegroups.com Received: from mga05.intel.com (mga05.intel.com. [192.55.52.43]) by gmr-mx.google.com with ESMTPS id n18si8931401pfb.2.2016.11.08.04.41.43 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 08 Nov 2016 04:41:43 -0800 (PST) Date: Tue, 8 Nov 2016 20:50:06 +0800 From: Chen Yu To: x86@kernel.org Cc: Pavel Machek , Ingo Molnar , "H. Peter Anvin" , linux-pm@vger.kernel.org, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, Thomas Gleixner , "Rafael J. Wysocki" , Len Brown , John Stultz , Xunlei Pang Subject: [rtc-linux] Re: [PATCH 1/2][RFC v6] timekeeping: Ignore the bogus sleep time if pm_trace is enabled Message-ID: <20161108125006.GD7191@yu-desktop-1.sh.intel.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 In-Reply-To: Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , On Tue, Nov 08, 2016 at 05:01:35PM +0800, Chen Yu wrote: > From: Thomas Gleixner > > Previously we encountered some memory overflow issues due to > the bogus sleep time brought by inconsistent rtc, which is > triggered when pm_trace is enabled, and we have fixed it > in recent kernel. However it's improper in the first place > to call __timekeeping_inject_sleeptime() in case that pm_trace > is enabled simply because that "hash" time value will wreckage > the timekeeping subsystem. > > This patch is to bypass the bogus rtc interval when pm_trace is enabled. > > Cc: Thomas Gleixner > Cc: "Rafael J. Wysocki" > Cc: Len Brown > Cc: John Stultz > Cc: Xunlei Pang > Signed-off-by: Chen Yu > --- > [cut] Will resend another version. Thanks. -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933422AbcKHMlp (ORCPT ); Tue, 8 Nov 2016 07:41:45 -0500 Received: from mga07.intel.com ([134.134.136.100]:39428 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752883AbcKHMlo (ORCPT ); Tue, 8 Nov 2016 07:41:44 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,462,1473145200"; d="scan'208";a="1065572052" Date: Tue, 8 Nov 2016 20:50:06 +0800 From: Chen Yu To: x86@kernel.org Cc: Pavel Machek , Ingo Molnar , "H. Peter Anvin" , linux-pm@vger.kernel.org, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, Thomas Gleixner , "Rafael J. Wysocki" , Len Brown , John Stultz , Xunlei Pang Subject: Re: [PATCH 1/2][RFC v6] timekeeping: Ignore the bogus sleep time if pm_trace is enabled Message-ID: <20161108125006.GD7191@yu-desktop-1.sh.intel.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 08, 2016 at 05:01:35PM +0800, Chen Yu wrote: > From: Thomas Gleixner > > Previously we encountered some memory overflow issues due to > the bogus sleep time brought by inconsistent rtc, which is > triggered when pm_trace is enabled, and we have fixed it > in recent kernel. However it's improper in the first place > to call __timekeeping_inject_sleeptime() in case that pm_trace > is enabled simply because that "hash" time value will wreckage > the timekeeping subsystem. > > This patch is to bypass the bogus rtc interval when pm_trace is enabled. > > Cc: Thomas Gleixner > Cc: "Rafael J. Wysocki" > Cc: Len Brown > Cc: John Stultz > Cc: Xunlei Pang > Signed-off-by: Chen Yu > --- > [cut] Will resend another version. Thanks.