From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f200.google.com (mail-pf0-f200.google.com [209.85.192.200]) by kanga.kvack.org (Postfix) with ESMTP id 94E6B6B025E for ; Tue, 8 Nov 2016 18:17:29 -0500 (EST) Received: by mail-pf0-f200.google.com with SMTP id 144so60658702pfv.5 for ; Tue, 08 Nov 2016 15:17:29 -0800 (PST) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org. [140.211.169.12]) by mx.google.com with ESMTPS id p62si39003794pfi.27.2016.11.08.15.17.28 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 08 Nov 2016 15:17:28 -0800 (PST) Date: Tue, 8 Nov 2016 15:17:27 -0800 From: Andrew Morton Subject: Re: [patch] mm, slab: faster active and free stats Message-Id: <20161108151727.b64035da825c69bced88b46d@linux-foundation.org> In-Reply-To: References: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: David Rientjes Cc: Greg Thelen , Aruna Ramakrishna , Christoph Lameter , Joonsoo Kim , linux-kernel@vger.kernel.org, linux-mm@kvack.org On Tue, 8 Nov 2016 15:06:45 -0800 (PST) David Rientjes wrote: > Reading /proc/slabinfo or monitoring slabtop(1) can become very expensive > if there are many slab caches and if there are very lengthy per-node > partial and/or free lists. > > Commit 07a63c41fa1f ("mm/slab: improve performance of gathering slabinfo > stats") addressed the per-node full lists which showed a significant > improvement when no objects were freed. This patch has the same > motivation and optimizes the remainder of the usecases where there are > very lengthy partial and free lists. > > This patch maintains per-node active_slabs (full and partial) and > free_slabs rather than iterating the lists at runtime when reading > /proc/slabinfo. Are there any nice numbers you can share? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753149AbcKHXRb (ORCPT ); Tue, 8 Nov 2016 18:17:31 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:50574 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751564AbcKHXR3 (ORCPT ); Tue, 8 Nov 2016 18:17:29 -0500 Date: Tue, 8 Nov 2016 15:17:27 -0800 From: Andrew Morton To: David Rientjes Cc: Greg Thelen , Aruna Ramakrishna , Christoph Lameter , Joonsoo Kim , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [patch] mm, slab: faster active and free stats Message-Id: <20161108151727.b64035da825c69bced88b46d@linux-foundation.org> In-Reply-To: References: X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 8 Nov 2016 15:06:45 -0800 (PST) David Rientjes wrote: > Reading /proc/slabinfo or monitoring slabtop(1) can become very expensive > if there are many slab caches and if there are very lengthy per-node > partial and/or free lists. > > Commit 07a63c41fa1f ("mm/slab: improve performance of gathering slabinfo > stats") addressed the per-node full lists which showed a significant > improvement when no objects were freed. This patch has the same > motivation and optimizes the remainder of the usecases where there are > very lengthy partial and free lists. > > This patch maintains per-node active_slabs (full and partial) and > free_slabs rather than iterating the lists at runtime when reading > /proc/slabinfo. Are there any nice numbers you can share?