Re: [PATCH kvm-unit-tests 17/17] x86/unittests: add intel-iommu test

[Peter Xu <peterx@redhat.com>]

On Tue, Nov 08, 2016 at 11:39:55AM +0100, Andrew Jones wrote:

[...]

> > For this test, the latest command line should be:
> > 
> >   -M q35,kernel-irqchip=split -device intel-iommu,intremap=on -device edu
> > 
> > However it will fail if kernel version <4.7 (without x2apic supported
> > KVM). No chance for a report_skip().
> > 
> > I can use eim=off to avoid that check, however, if with "eim=off", we have:
> > 
> >   -M q35,kernel-irqchip=split -device intel-iommu,intremap=on,eim=off -device edu
> > 
> > It requires QEMU to be latest (>2.8). Otherwise QEMU will report "eim
> > property not found" and we lost chance to report as well.
> > 
> > So, I just chose to use pc-q35-2.7 here. Not sure whether this is a
> > good idea.
> 
> I think we just shouldn't care. Either this test is run on the latest
> kernel and qemu, or it will fail. Hopefully something ends up in test.log
> that indicates it failed due to an old kernel or old qemu. Old qemu is
> clear from the "eim property not found"

I see. Then let me make it simpler. I'll use q35 directly with eim=off.

> 
> Alternatively we can build support into runtime to capture kernel, qemu
> versions and compare them against new unittests.cfg {kvm,qemu}_minver
> fields. That would be a different series though, and will require
> extending mkstandalone as well. Feel free to add it to your TODO. If you
> do, then I hope you like Bash :-)

Sure. It's in. And I like Bash. :-)

Thanks,

-- peterx