From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukas Wunner Subject: Re: [PATCH] drm/nouveau: fix LEDS_CLASS=m configuration Date: Tue, 8 Nov 2016 17:07:01 +0100 Message-ID: <20161108160701.GC6983@wunner.de> References: <20161108135721.2142330-1-arnd@arndb.de> <12373137.2mgsQIhOfV@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <12373137.2mgsQIhOfV@wuerfel> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: nouveau-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Nouveau" To: Arnd Bergmann Cc: "nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" , "dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" , Ben Skeggs , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: nouveau.vger.kernel.org T24gVHVlLCBOb3YgMDgsIDIwMTYgYXQgMDQ6NTI6NDlQTSArMDEwMCwgQXJuZCBCZXJnbWFubiB3 cm90ZToKPiBUaGUgdW5kZXJseWluZyBwcm9ibGVtIGlzIHRoYXQgd2UgYWxyZWFkeSBoYXZlIGEg bnVtYmVyIG9mIG90aGVyCj4gc3ltYm9scyB0aGF0IGVpdGhlciBoYXZlICJkZXBlbmRzIG9uIExF RFNfQ0xBU1MiIG9yCj4gInNlbGVjdCBMRURTX0NMQVNTIi4gVG8gY2xlYW4gdGhhdCB1cCBwcm9w ZXJseSwgd2Ugc2hvdWxkIGVpdGhlcgo+IG1ha2UgdGhlIHN5bWJvbCBpdHNlbGYgaGlkZGVuIGFu ZCBvbmx5IHNlbGVjdCBpdCBmcm9tIG90aGVyIGRyaXZlcnMsCj4gb3IgdXNlICJkZXBlbmRzIG9u IExFRFNfQ0xBU1MiIGV2ZXJ5d2hlcmUuCj4gCj4gQW5vdGhlciBvcHRpb24gaXMgdG8gdXNlIHRo ZSBJU19SRUFDSEFCTEUoKSBtYWNybyBpbnN0ZWFkIG9mIElTX0VOQUJMRUQoKQo+IGluIHRoZSBo ZWFkZXIgZmlsZSwgdG8gc3R1YiBvdXQgdGhlIGNhbGxzIGludG8gdGhlIG5ldyBmaWxlLCBidXQK PiB0aGF0IGNhbiBiZSBhIGJpdCBjb25mdXNpbmcuCgpXaHkgZG9uJ3QgeW91IGp1c3QgYWRkIGVt cHR5IGlubGluZSBzdHVicyBmb3Igbm91dmVhdV9sZWRfaW5pdCAvIF9maW5pIC8KX3N1c3BlbmQg LyBfcmVzdW1lPwoKVGhhbmtzLAoKTHVrYXMKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KTm91dmVhdSBtYWlsaW5nIGxpc3QKTm91dmVhdUBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9ub3V2ZWF1Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932167AbcKHQF6 (ORCPT ); Tue, 8 Nov 2016 11:05:58 -0500 Received: from mailout2.hostsharing.net ([83.223.90.233]:39813 "EHLO mailout2.hostsharing.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751786AbcKHQF5 (ORCPT ); Tue, 8 Nov 2016 11:05:57 -0500 Date: Tue, 8 Nov 2016 17:07:01 +0100 From: Lukas Wunner To: Arnd Bergmann Cc: Ilia Mirkin , "nouveau@lists.freedesktop.org" , Ben Skeggs , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" Subject: Re: [Nouveau] [PATCH] drm/nouveau: fix LEDS_CLASS=m configuration Message-ID: <20161108160701.GC6983@wunner.de> References: <20161108135721.2142330-1-arnd@arndb.de> <12373137.2mgsQIhOfV@wuerfel> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <12373137.2mgsQIhOfV@wuerfel> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 08, 2016 at 04:52:49PM +0100, Arnd Bergmann wrote: > The underlying problem is that we already have a number of other > symbols that either have "depends on LEDS_CLASS" or > "select LEDS_CLASS". To clean that up properly, we should either > make the symbol itself hidden and only select it from other drivers, > or use "depends on LEDS_CLASS" everywhere. > > Another option is to use the IS_REACHABLE() macro instead of IS_ENABLED() > in the header file, to stub out the calls into the new file, but > that can be a bit confusing. Why don't you just add empty inline stubs for nouveau_led_init / _fini / _suspend / _resume? Thanks, Lukas