From mboxrd@z Thu Jan 1 00:00:00 1970 From: will.deacon@arm.com (Will Deacon) Date: Tue, 8 Nov 2016 16:36:43 +0000 Subject: [PATCH v2 0/2] arm64: fix the bugs found in the hugetlb test In-Reply-To: <20161108140909.GF29087@e104818-lin.cambridge.arm.com> References: <1478583879-14654-1-git-send-email-shijie.huang@arm.com> <20161108140909.GF29087@e104818-lin.cambridge.arm.com> Message-ID: <20161108163642.GE20591@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Nov 08, 2016 at 02:09:09PM +0000, Catalin Marinas wrote: > On Tue, Nov 08, 2016 at 01:44:37PM +0800, Huang Shijie wrote: > > (3) The test result in the Softiron and Juno-r1 boards: > > > > This detail test result shows below (both the "make func" & "make stress"): > > > > 4KB granule: > > > > 1.1) PTE + Contiguous bit : 4K x 16 = 64K (per huge page size) > > Test result : PASS > > > > 1.2) PMD : 2M x 1 = 2M (per huge page size) > > Test result : PASS > > > > 1.3) PMD + Contiguous bit : 2M x 16 = 32M (per huge page size) > > Test result : PASS > > > > 64KB granule: > > > > 3.1) PTE + Contiguous bit : 64K x 32 = 2M (per huge page size) > > Test result : PASS > > > > 3.2) PMD + Contiguous bit : 512M x 32 = 16G (per huge page size) > > Test result : no hardware to support this test > > Don't we have support for single (non-contiguous) PMD huge page with 64K > pages (512M per huge page)? I gave it a try and it seems to work (though > without your patches applied ;)). > > > Huang Shijie (2): > > arm64: hugetlb: remove the wrong pmd check in find_num_contig() > > arm64: hugetlb: fix the wrong address for several functions > > For these patches: > > Reviewed-by: Catalin Marinas > > I'm not sure whether Will plans to push them into 4.9. AFAICT, the > contiguous huge pages never worked properly, so we may not count it as a > regression but a new feature. If Will doesn't take them, I'll queue the > patches for 4.10. Right, given that it's never worked and the failure only seems to crop up in synthetic testing, I think you can queue these for 4.10. Will From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753992AbcKHQgm (ORCPT ); Tue, 8 Nov 2016 11:36:42 -0500 Received: from foss.arm.com ([217.140.101.70]:35956 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751243AbcKHQgl (ORCPT ); Tue, 8 Nov 2016 11:36:41 -0500 Date: Tue, 8 Nov 2016 16:36:43 +0000 From: Will Deacon To: Catalin Marinas Cc: Huang Shijie , dwoods@mellanox.com, steve.capper@arm.com, linux-kernel@vger.kernel.org, kaly.xin@arm.com, akpm@linux-foundation.org, nd@arm.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 0/2] arm64: fix the bugs found in the hugetlb test Message-ID: <20161108163642.GE20591@arm.com> References: <1478583879-14654-1-git-send-email-shijie.huang@arm.com> <20161108140909.GF29087@e104818-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161108140909.GF29087@e104818-lin.cambridge.arm.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 08, 2016 at 02:09:09PM +0000, Catalin Marinas wrote: > On Tue, Nov 08, 2016 at 01:44:37PM +0800, Huang Shijie wrote: > > (3) The test result in the Softiron and Juno-r1 boards: > > > > This detail test result shows below (both the "make func" & "make stress"): > > > > 4KB granule: > > > > 1.1) PTE + Contiguous bit : 4K x 16 = 64K (per huge page size) > > Test result : PASS > > > > 1.2) PMD : 2M x 1 = 2M (per huge page size) > > Test result : PASS > > > > 1.3) PMD + Contiguous bit : 2M x 16 = 32M (per huge page size) > > Test result : PASS > > > > 64KB granule: > > > > 3.1) PTE + Contiguous bit : 64K x 32 = 2M (per huge page size) > > Test result : PASS > > > > 3.2) PMD + Contiguous bit : 512M x 32 = 16G (per huge page size) > > Test result : no hardware to support this test > > Don't we have support for single (non-contiguous) PMD huge page with 64K > pages (512M per huge page)? I gave it a try and it seems to work (though > without your patches applied ;)). > > > Huang Shijie (2): > > arm64: hugetlb: remove the wrong pmd check in find_num_contig() > > arm64: hugetlb: fix the wrong address for several functions > > For these patches: > > Reviewed-by: Catalin Marinas > > I'm not sure whether Will plans to push them into 4.9. AFAICT, the > contiguous huge pages never worked properly, so we may not count it as a > regression but a new feature. If Will doesn't take them, I'll queue the > patches for 4.10. Right, given that it's never worked and the failure only seems to crop up in synthetic testing, I think you can queue these for 4.10. Will