From: Eric Biggers <ebiggers@google.com>
To: Martin Willi <martin@strongswan.org>
Cc: "Jason A. Donenfeld" <Jason@zx2c4.com>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
"René van Dorst" <opensource@vdorst.com>
Subject: Re: [PATCH v4] poly1305: generic C can be faster on chips with slow unaligned access
Date: Tue, 8 Nov 2016 09:26:26 -0800 [thread overview]
Message-ID: <20161108172626.GA99078@google.com> (raw)
In-Reply-To: <1478591559.5216.7.camel@strongswan.org>
On Tue, Nov 08, 2016 at 08:52:39AM +0100, Martin Willi wrote:
>
>
> Not sure what the exact alignment rules for key/iv are, but maybe we
> want to replace the same function in chacha20_generic.c as well?
>
> Martin
chacha20-generic provides a blkcipher API and sets an alignmask of sizeof(u32)
- 1. This applies to the key buffer for ->setkey() and to the mapped addresses
for the input/output buffers and IV during the blkcipher walk. So it does not
appear to have the problems that poly1305 has.
I do however see one small problem which is that
'u8 stream[CHACHA20_BLOCK_SIZE];' is, strictly speaking, not guaranteed to be
aligned to u32.
Eric
next prev parent reply other threads:[~2016-11-08 17:26 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-02 17:58 [PATCH] poly1305: generic C can be faster on chips with slow unaligned access Jason A. Donenfeld
2016-11-02 20:09 ` Herbert Xu
2016-11-02 20:47 ` Sandy Harris
2016-11-02 21:06 ` Jason A. Donenfeld
2016-11-02 21:08 ` Herbert Xu
2016-11-02 21:25 ` Jason A. Donenfeld
2016-11-02 21:26 ` Herbert Xu
2016-11-02 22:00 ` Jason A. Donenfeld
2016-11-03 0:49 ` Herbert Xu
2016-11-03 7:24 ` Jason A. Donenfeld
2016-11-03 17:08 ` David Miller
2016-11-03 22:20 ` Jason A. Donenfeld
2016-11-03 22:20 ` Jason A. Donenfeld
2016-11-03 22:20 ` [WireGuard] " Jason A. Donenfeld
2016-11-04 17:37 ` Eric Biggers
2016-11-04 17:37 ` [WireGuard] " Eric Biggers
2016-11-07 18:08 ` Jason A. Donenfeld
2016-11-07 18:08 ` Jason A. Donenfeld
2016-11-07 18:08 ` [WireGuard] " Jason A. Donenfeld
2016-11-07 18:23 ` Jason A. Donenfeld
2016-11-07 18:23 ` Jason A. Donenfeld
2016-11-07 18:23 ` [WireGuard] " Jason A. Donenfeld
2016-11-07 18:26 ` Eric Biggers
2016-11-07 18:26 ` Eric Biggers
2016-11-07 18:26 ` [WireGuard] " Eric Biggers
2016-11-07 19:02 ` Jason A. Donenfeld
2016-11-07 19:02 ` Jason A. Donenfeld
2016-11-07 19:02 ` [WireGuard] " Jason A. Donenfeld
2016-11-07 19:25 ` Eric Biggers
2016-11-07 19:25 ` Eric Biggers
2016-11-07 19:25 ` [WireGuard] " Eric Biggers
2016-11-07 19:41 ` Jason A. Donenfeld
2016-11-07 19:41 ` Jason A. Donenfeld
2016-11-07 19:41 ` [WireGuard] " Jason A. Donenfeld
2016-11-07 19:12 ` [PATCH v2] " Jason A. Donenfeld
2016-11-07 19:43 ` [PATCH v3] " Jason A. Donenfeld
2016-11-12 23:27 ` kbuild test robot
2016-11-07 19:47 ` [PATCH v4] " Jason A. Donenfeld
2016-11-07 20:40 ` Eric Biggers
2016-11-08 7:52 ` Martin Willi
2016-11-08 17:26 ` Eric Biggers [this message]
2016-11-13 11:29 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161108172626.GA99078@google.com \
--to=ebiggers@google.com \
--cc=Jason@zx2c4.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin@strongswan.org \
--cc=opensource@vdorst.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.