From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Tobias Klauser <tklauser@distanz.ch>
Cc: Alexei Starovoitov <ast@kernel.org>,
netdev@vger.kernel.org, Josef Bacik <jbacik@fb.com>
Subject: Re: [PATCH] bpf: Remove unused but set variables
Date: Tue, 8 Nov 2016 13:45:40 -0800 [thread overview]
Message-ID: <20161108214538.GA41350@ast-mbp.thefacebook.com> (raw)
In-Reply-To: <20161108154028.13334-1-tklauser@distanz.ch>
On Tue, Nov 08, 2016 at 04:40:28PM +0100, Tobias Klauser wrote:
> Remove the unused but set variables min_set and max_set in
> adjust_reg_min_max_vals to fix the following warning when building with
> 'W=1':
>
> kernel/bpf/verifier.c:1483:7: warning: variable ‘min_set’ set but not used [-Wunused-but-set-variable]
>
> There is no warning about max_set being unused, but since it is only
> used in the assignment of min_set it can be removed as well.
>
> They were introduced in commit 484611357c19 ("bpf: allow access into map
> value arrays") but seem to have never been used.
>
> Cc: Josef Bacik <jbacik@fb.com>
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
> ---
Acked-by: Alexei Starovoitov <ast@kernel.org>
next prev parent reply other threads:[~2016-11-08 21:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-08 15:40 [PATCH] bpf: Remove unused but set variables Tobias Klauser
2016-11-08 21:45 ` Alexei Starovoitov [this message]
2016-11-10 2:15 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161108214538.GA41350@ast-mbp.thefacebook.com \
--to=alexei.starovoitov@gmail.com \
--cc=ast@kernel.org \
--cc=jbacik@fb.com \
--cc=netdev@vger.kernel.org \
--cc=tklauser@distanz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.