Re: [conntrack-tools PATCH 1/3] log: introduce a mechanism to know if log was initialized

[Pablo Neira Ayuso <pablo@netfilter.org>]

On Fri, Nov 04, 2016 at 11:37:02AM +0100, Arturo Borrero Gonzalez wrote:
> This will allow to call dlog() function from all the points in the
> execution at runtime.
> 
> If the log was not initialized, then we just fprintf and return.
> 
> By now, we can't init the log engine earlier because we require config
> from the user, so there is a egg-chicken problem.
> This means that we can't log parsing messages to logfiles but only to
> stderr/stdout.

Series applied, thanks Arturo.

A couple of things that would be good to revisit, just for the record:

1) Get rid of deprecated stuff. By digging into the git log history I
   guess you can probably find that they have been deprecated since
   ~2008, so it's been already enough time for people to update
   configuration files.

2) Make sure the configuration parser works fine with defaults, I mean
   with the bare minimum configuration. I remember reports from people
   that wrote configuration files from scratch, that were not working.
   So I pointed them to the example files to use as template.

Thanks.