From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752586AbcKIAAh (ORCPT <rfc822;w@1wt.eu>);
        Tue, 8 Nov 2016 19:00:37 -0500
Received: from mail-pf0-f193.google.com ([209.85.192.193]:33562 "EHLO
        mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751677AbcKIAAf (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 8 Nov 2016 19:00:35 -0500
Date: Tue, 8 Nov 2016 16:00:32 -0800
From: Brian Norris <computersforpeace@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Andy Whitcroft <apw@canonical.com>, Joe Perches <joe@perches.com>,
        linux-kernel@vger.kernel.org,
        Linus Torvalds <torvalds@linux-foundation.org>,
        SF Markus Elfring <elfring@users.sourceforge.net>,
        Jerome Forissier <jerome.forissier@linaro.org>
Subject: Re: [PATCH] checkpatch: fix uninitialized var when run with --no-tree
Message-ID: <20161109000032.GA71749@google.com>
References: <1477707991-140274-1-git-send-email-briannorris@chromium.org>
 <20161029023609.GA48401@google.com>
 <20161108151040.4283451c39240dd32bdd61dc@linux-foundation.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20161108151040.4283451c39240dd32bdd61dc@linux-foundation.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Nov 08, 2016 at 03:10:40PM -0800, Andrew Morton wrote:
> I already have the below.  Good enough?

Sure, good enough. Though it does have the same tiny awkwardness as my
v1.

> From: Jerome Forissier <jerome.forissier@linaro.org>
> Subject: checkpatch: don't try to get maintained status when --no-tree is given
> 
> Fixes the following warning:
> Use of uninitialized value $root in concatenation (.) or string at /path/to/checkpatch.pl line 764.
> 
> Link: http://lkml.kernel.org/r/1476719709-16668-1-git-send-email-jerome.forissier@linaro.org
> Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
> Acked-by: Joe Perches <joe@perches.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
> 
>  scripts/checkpatch.pl |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff -puN scripts/checkpatch.pl~checkpatch-dont-try-to-get-maintained-status-when-no-tree-is-given scripts/checkpatch.pl
> --- a/scripts/checkpatch.pl~checkpatch-dont-try-to-get-maintained-status-when-no-tree-is-given
> +++ a/scripts/checkpatch.pl
> @@ -761,7 +761,7 @@ sub seed_camelcase_file {
>  sub is_maintained_obsolete {
>  	my ($filename) = @_;
>  
> -	return 0 if (!(-e "$root/scripts/get_maintainer.pl"));
> +	return 0 if (!$tree || !(-e "$root/scripts/get_maintainer.pl"));
>  
>  	my $status = `perl $root/scripts/get_maintainer.pl --status --nom --nol --nogit --nogit-fallback -f $filename 2>&1`;
>  
> _
> 

FWIW:

Reviewed-by: Brian Norris <computersforpeace@gmail.com>