From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: Damien Le Moal <damien.lemoal@wdc.com>,
Christoph Hellwig <hch@lst.de>,
Logan Gunthorpe <logang@deltatee.com>,
linux-block@vger.kernel.org, Mike Snitzer <snitzer@redhat.com>
Subject: Re: BUG: Hung task timeouts in for-4.10/dio
Date: Wed, 9 Nov 2016 03:05:17 +0100 [thread overview]
Message-ID: <20161109020517.GA759@lst.de> (raw)
In-Reply-To: <03cda65e-3a82-6ccd-861b-67a55888eb19@kernel.dk>
On Tue, Nov 08, 2016 at 07:02:52PM -0700, Jens Axboe wrote:
> It smells like an accounting error. One thing that I don't like with the
> current scheme is the implicit knowledge that certain flags imply sync
> as well. If we clear any of those flags, then we screw up accounting at
> the end.
>
> Does this make a difference?
That looks interesting. In the meantime I reproduced a similar
hang, but only half-way through an xfstests run with a non-mq device.
I'll see how far I can narrow it down and will give your patch a try as
well.
next prev parent reply other threads:[~2016-11-09 2:05 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-08 18:16 BUG: Hung task timeouts in for-4.10/dio Logan Gunthorpe
2016-11-08 18:21 ` Jens Axboe
2016-11-08 18:59 ` Logan Gunthorpe
2016-11-08 19:01 ` Jens Axboe
2016-11-08 19:03 ` Logan Gunthorpe
2016-11-08 19:19 ` Jens Axboe
2016-11-08 19:47 ` Logan Gunthorpe
2016-11-08 19:50 ` Jens Axboe
[not found] ` <84693d82-b8dc-42b3-03da-055def7499a0@deltatee.com>
2016-11-08 20:21 ` Jens Axboe
2016-11-08 21:08 ` Mike Snitzer
2016-11-09 0:50 ` Damien Le Moal
2016-11-09 1:09 ` Christoph Hellwig
2016-11-09 1:25 ` Damien Le Moal
2016-11-09 1:28 ` Jens Axboe
2016-11-09 2:02 ` Jens Axboe
2016-11-09 2:05 ` Christoph Hellwig [this message]
2016-11-09 2:11 ` Jens Axboe
2016-11-09 2:17 ` Damien Le Moal
2016-11-09 2:38 ` Jens Axboe
2016-11-09 2:40 ` Christoph Hellwig
2016-11-09 2:45 ` Jens Axboe
2016-11-09 2:55 ` Damien Le Moal
2016-11-09 17:03 ` Logan Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161109020517.GA759@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=damien.lemoal@wdc.com \
--cc=linux-block@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.